Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added akats7 as codeowner #31049

Merged
merged 3 commits into from
Feb 7, 2024
Merged

Added akats7 as codeowner #31049

merged 3 commits into from
Feb 7, 2024

Conversation

akats7
Copy link
Contributor

@akats7 akats7 commented Feb 5, 2024

Description:
Hey @crobert-1, got the codeowners are not members error when running make update-codeowners. Is that still the correct way to add myself to the codeowners file, should I add my id manually?

@crobert-1
Copy link
Member

Can you share your error message? I see you're a member of the OpenTelemetry community so I want to confirm it's not failing on your username.

Otherwise, if the command isn't working, you can add yourself manually to the CODEOWNERS file.

@akats7
Copy link
Contributor Author

akats7 commented Feb 5, 2024

Can you share your error message? I see you're a member of the OpenTelemetry community so I want to confirm it's not failing on your username.

Otherwise, if the command isn't working, you can add yourself manually to the CODEOWNERS file.

Its includes a good chunk of other users as well

codeowners are not members: BinaryFissionGames, Frapschen, JonathanWamsley, MovieStoreGuy, Mrod1598, StefanKurek, VihasMakwana, adrielp, ag-ramachandran, akats7, alexvanboxel, altuner, antonblock, armstrmi, atingchen, atoulme, avadhut123pisal, bertysentry, braydonk, bryan-aguilar, chrroberts-pure, codeboten, cparkins, cpheps, damemi, dashpole, dehaansa, dgoscn, eedorenko, erichsueh3, evan-bradley, fatsheep9146, fchikwekwe, gjanco, greatestusername, hickeyma, hughesjj, jacobmarble, jamesmoessis, jmacd, jsuereth, kentquirk, khyatigandhi6, kkujawa-sumo, liustanley, mapno, mar4uk, marctc, martin-majlis-s1, matej-g, mcardy, moh-osman3, mrsillydog, nslaughter, pavankrish123, pcwiese, pjanotti, portertech, povilasv, psx95, pxaws, rapphil, rmfitzpatrick, rnishtala-sumo, rogercoll, samiura, schmikei, shalper2, smithclay, srprash, swiatekm-sumo, tamir-michaeli, tomaz-s1, varunraiko, wangzlei, yotamloe, zdaratom-s1

@akats7
Copy link
Contributor Author

akats7 commented Feb 5, 2024

@crobert-1 I'll add myself manually in that case

@atoulme atoulme added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Feb 5, 2024
@atoulme
Copy link
Contributor

atoulme commented Feb 5, 2024

You're not a member of the opentelemetry organization and cannot query for members of the organization via the REST API.

@crobert-1
Copy link
Member

Its includes a good chunk of other users as well

This is actually an access token issue, you need to set up a personal access token to be able to properly run make update-codeowners.

You're welcome to update it either way.

@crobert-1
Copy link
Member

crobert-1 commented Feb 5, 2024

You're not a member of the opentelemetry organization and cannot query for members of the organization via the REST API.

When the error message includes so many members it's an access token issue. (There are approvers and maintainers in this repository included as not being members in the output, for example.)

@akats7
Copy link
Contributor Author

akats7 commented Feb 5, 2024

Its includes a good chunk of other users as well

This is actually an access token issue, you need to set up a personal access token to be able to properly run make update-codeowners.

You're welcome to update it either way.

Hmm I was getting an auth error before and then generated a new PAT, maybe missed somethign

@djaglowski djaglowski added the ready to merge Code review completed; ready to merge by maintainers label Feb 6, 2024
@codeboten codeboten merged commit 5bd9a2e into open-telemetry:main Feb 7, 2024
147 checks passed
@github-actions github-actions bot added this to the next release milestone Feb 7, 2024
anthoai97 pushed a commit to anthoai97/opentelemetry-collector-contrib that referenced this pull request Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
connector/failover ready to merge Code review completed; ready to merge by maintainers Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants