Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore][pkg/stanza] Remove unnecessary slice of entries #31000

Merged
merged 5 commits into from
Feb 2, 2024
Merged

[chore][pkg/stanza] Remove unnecessary slice of entries #31000

merged 5 commits into from
Feb 2, 2024

Conversation

djaglowski
Copy link
Member

@djaglowski djaglowski commented Feb 1, 2024 •
edited
Loading

Depends on #30999

We are already aggregating the "recombined field" into a buffer, so we don't need to keep a handle to all recombined entries.

@djaglowski djaglowski mentioned this pull request Feb 1, 2024
Merged
@djaglowski djaglowski marked this pull request as ready for review February 1, 2024 17:47
@djaglowski djaglowski requested a review from a team as a code owner February 1, 2024 17:47
@djaglowski djaglowski mentioned this pull request Feb 2, 2024
Merged
@djaglowski djaglowski merged commit c11044b into open-telemetry:main Feb 2, 2024
142 checks passed
@djaglowski djaglowski deleted the pkg-stanza-recombine-4 branch February 2, 2024 16:43
@github-actions github-actions bot added this to the next release milestone Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mx-psi mx-psi mx-psi approved these changes

Assignees

@bogdandrutu bogdandrutu

Labels
pkg/stanza
Projects
None yet
Milestone
v0.94.0
Development

Successfully merging this pull request may close these issues.
3 participants
@djaglowski @mx-psi @bogdandrutu