[chore][exporter/splunkhecexporter] Enable goleak check #30968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crobert-1
commented
Feb 1, 2024
dmitryax
reviewed
Feb 1, 2024
crobert-1
commented
Feb 1, 2024
crobert-1
force-pushed
the
goleak_splunkhecexp
branch
from
216b0dc
to
a84c4e6
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
- Refactor test - Fix typos
atoulme
approved these changes
Mar 8, 2024
dmitryax
approved these changes
Mar 8, 2024
DougManton
pushed a commit
to DougManton/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
…ry#30968) **Description:** This enables `goleak` checks for the splunkhecexporter, to help ensure no goroutines are being leaked. This is a test only change, some `Shutdown` calls were missing, as well as channel send operations were blocking in tests because there was no one reading from the channel. **Link to tracking Issue:** open-telemetry#30438 **Testing:** Existing tests are all passing as well as added `goleak` check.
XinRanZhAWS
pushed a commit
to XinRanZhAWS/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
…ry#30968) **Description:** This enables `goleak` checks for the splunkhecexporter, to help ensure no goroutines are being leaked. This is a test only change, some `Shutdown` calls were missing, as well as channel send operations were blocking in tests because there was no one reading from the channel. **Link to tracking Issue:** open-telemetry#30438 **Testing:** Existing tests are all passing as well as added `goleak` check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This enables
goleakchecks for the splunkhecexporter, to help ensure no goroutines are being leaked. This is a test only change, someShutdowncalls were missing, as well as channel send operations were blocking in tests because there was no one reading from the channel.Link to tracking Issue:
#30438
Testing:
Existing tests are all passing as well as added
goleakcheck.