Change default Docker client API version from 1.22 to 1.24 #30927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
reviewed
Jan 31, 2024
39aff7b
to
5bd4bff
Compare
crobert-1
reviewed
Jan 31, 2024
5bd4bff
to
a85df5e
Compare
crobert-1
approved these changes
Jan 31, 2024
29e5e90
to
ed42415
Compare
|
I filed #31005 for the failing CI/CD test, unrelated to this change. |
|
@crobert-1 please rebase |
@samiura 🙂 |
ae8821b
to
9a11337
Compare
|
sorry for the delay, rebased. |
9f2d62c
to
b070900
Compare
b070900
to
6c1c545
Compare
dmitryax
approved these changes
Feb 1, 2024
| @@ -18,7 +18,7 @@ The Docker observer extension is a [Receiver Creator](../../../receiver/receiver | |||
| container endpoints discovered through the Docker API. Only containers that are in the state of `Running` and not `Paused` will emit endpoints. | |||
| This observer watches the Docker engine's stream of events to dynamically create, update, and remove endpoints as events are processed. | |||
|
|
|||
| Requires Docker API Version 1.22+. | |||
| Requires Docker API Version 1.24+. | |||
There was a problem hiding this comment.
Curious why this line is needed if it's configurable. Seems confusing. Feel free to remove in a separate PR if it makes sense
There was a problem hiding this comment.
this is meant to say to require a minimum of 1.24. A better wording would be Requires Docker API with a version of 1.24 or higher.
There was a problem hiding this comment.
I thought it could be configured with a lower version. Maybe I misunderstood
There was a problem hiding this comment.
The issue has a link to an explanation as a commit message to the moby project:
moby/moby@08e4e88
The daemon currently provides support for API versions all the way back
to v1.12, which is the version of the API that shipped with docker 1.0. On
Windows, the minimum supported version is v1.24.
Such old versions of the client are rare, and supporting older API versions
has accumulated significant amounts of code to remain backward-compatible
(which is largely untested, and a "best-effort" at most).
This patch updates the minimum API version to v1.24, which is the fallback
API version used when API-version negotiation fails. The intent is to start
deprecating older API versions, but no code is removed yet as part of this
patch, and a DOCKER_MIN_API_VERSION environment variable is added, which
allows overriding the minimum version (to allow restoring the behavior from
before this patch).
With this patch the daemon defaults to API v1.24 as minimum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Docker Client API default has been upgraded from 1.22 to 1.24. The details of the requirements to this change has been given in the accompanying issue with docker upstream PRs.
Link to tracking Issue:
Fixes #30900
Testing: Updated unit tests accordingly and ran integration tests to make sure everything works as it should.
Documentation: