Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored pipeline selector #30904

Merged
merged 5 commits into from
Feb 1, 2024
Merged

Conversation

akats7
Copy link
Contributor

@akats7 akats7 commented Jan 31, 2024

Description:

This PR serves as a refactor for core logic of the connector, to further decouple the failover component from the pipeline_selector which will now be the exclusive component to deal with managing the index corresponding to the target consumers.

Testing:

Modified existing tests to align with changes.

Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @akats7. Seems much cleaner to me.

connector/failoverconnector/logs.go Outdated Show resolved Hide resolved
@djaglowski djaglowski merged commit 8b3ad33 into open-telemetry:main Feb 1, 2024
129 checks passed
@github-actions github-actions bot added this to the next release milestone Feb 1, 2024
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this pull request Feb 1, 2024
**Description:** 

This PR serves as a refactor for core logic of the connector, to further
decouple the failover component from the pipeline_selector which will
now be the exclusive component to deal with managing the index
corresponding to the target consumers.


**Testing:** 

Modified existing tests to align with changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants