[chore] Update components' medata.yaml distribution information to match core and contrib #30832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crobert-1
requested review from
djaglowski,
a team,
atoulme and
MovieStoreGuy
as code owners
github-actions
bot
requested review from
armstrmi,
pavolloffay,
pjanotti and
shalper2
songy23
approved these changes
Jan 29, 2024
pjanotti
approved these changes
Jan 29, 2024
codeboten
pushed a commit
that referenced
this pull request
Jan 29, 2024
…y released (#30838) Follow up to #30832, all of these components include `contrib` in their supported distributions list, but they are not actually currently included in [releases of `contrib`.](https://github.com/open-telemetry/opentelemetry-collector-releases/blob/main/distributions/otelcol-contrib/manifest.yaml) I believe since they're all labelled as `development` stability, they should not be included yet, so I'll remove from `metadata.yaml` instead of actually adding them to the release. Please let me know if I'm overstepping. From my understanding of [contributing a new component](https://github.com/open-telemetry/opentelemetry-collector-releases/blob/main/distributions/otelcol-contrib/manifest.yaml), we shouldn't include a distribution until it's actually being released. Happy to discuss if I'm misunderstanding something here.
djaglowski
approved these changes
Jan 31, 2024
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Feb 1, 2024
…y released (open-telemetry#30838) Follow up to open-telemetry#30832, all of these components include `contrib` in their supported distributions list, but they are not actually currently included in [releases of `contrib`.](https://github.com/open-telemetry/opentelemetry-collector-releases/blob/main/distributions/otelcol-contrib/manifest.yaml) I believe since they're all labelled as `development` stability, they should not be included yet, so I'll remove from `metadata.yaml` instead of actually adding them to the release. Please let me know if I'm overstepping. From my understanding of [contributing a new component](https://github.com/open-telemetry/opentelemetry-collector-releases/blob/main/distributions/otelcol-contrib/manifest.yaml), we shouldn't include a distribution until it's actually being released. Happy to discuss if I'm misunderstanding something here.
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Feb 1, 2024
…tch core and contrib (open-telemetry#30832) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> While investigating open-telemetry#30791 I noticed some components are included in releases but their `metadata.yaml` files don't actually include the distribution their included in. These updates should mean metadata is now up to date with what's included in the [core](https://github.com/open-telemetry/opentelemetry-collector-releases/blob/main/distributions/otelcol/manifest.yaml) and [contrib](https://github.com/open-telemetry/opentelemetry-collector-releases/blob/main/distributions/otelcol-contrib/manifest.yaml) releases.
anthoai97
pushed a commit
to anthoai97/opentelemetry-collector-contrib
that referenced
this pull request
Feb 12, 2024
…y released (open-telemetry#30838) Follow up to open-telemetry#30832, all of these components include `contrib` in their supported distributions list, but they are not actually currently included in [releases of `contrib`.](https://github.com/open-telemetry/opentelemetry-collector-releases/blob/main/distributions/otelcol-contrib/manifest.yaml) I believe since they're all labelled as `development` stability, they should not be included yet, so I'll remove from `metadata.yaml` instead of actually adding them to the release. Please let me know if I'm overstepping. From my understanding of [contributing a new component](https://github.com/open-telemetry/opentelemetry-collector-releases/blob/main/distributions/otelcol-contrib/manifest.yaml), we shouldn't include a distribution until it's actually being released. Happy to discuss if I'm misunderstanding something here.
anthoai97
pushed a commit
to anthoai97/opentelemetry-collector-contrib
that referenced
this pull request
Feb 12, 2024
…tch core and contrib (open-telemetry#30832) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> While investigating open-telemetry#30791 I noticed some components are included in releases but their `metadata.yaml` files don't actually include the distribution their included in. These updates should mean metadata is now up to date with what's included in the [core](https://github.com/open-telemetry/opentelemetry-collector-releases/blob/main/distributions/otelcol/manifest.yaml) and [contrib](https://github.com/open-telemetry/opentelemetry-collector-releases/blob/main/distributions/otelcol-contrib/manifest.yaml) releases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
While investigating #30791 I noticed some components are included in releases but their
metadata.yamlfiles don't actually include the distribution their included in. These updates should mean metadata is now up to date with what's included in the core and contrib releases.