Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][processor/spanmetrics] Remove albertteoh as codeowner #30815

Closed

Conversation

albertteoh
Copy link
Contributor

Description:
Move @albertteoh to emeritus codeowner for both spanmetrics processor and connector.

Signed-off-by: Albert Teoh <[email protected]>
@albertteoh albertteoh requested a review from a team as a code owner January 29, 2024 08:05
Copy link

CLA Missing ID CLA Not Signed

@@ -7,6 +7,7 @@ status:
distributions: [contrib, sumo, grafana, splunk, liatrio]
codeowners:
active: [portertech]
emeritus: [albertteoh]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed adding myself to emeritus for the connector.

@albertteoh
Copy link
Contributor Author

Odd that I'm asked to sign the EasyCLA doc, even though I'd done it already in the past. In any case, I've re-submitted it.

@mx-psi
Copy link
Member

mx-psi commented Jan 29, 2024

Odd that I'm asked to sign the EasyCLA doc, even though I'd done it already in the past. In any case, I've re-submitted it.

Looks like on this PR you are using a different email: https://github.com/open-telemetry/opentelemetry-collector-contrib/commit/f517b9e4f6215acb26f66136bfd5c677bc351f70.patch from the one you used here https://github.com/open-telemetry/opentelemetry-collector-contrib/commit/f19ca805ed6b91bf56c73ccbafd114a324a03b0a.patch

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @albertteoh

@albertteoh
Copy link
Contributor Author

Odd that I'm asked to sign the EasyCLA doc, even though I'd done it already in the past. In any case, I've re-submitted it.

Looks like on this PR you are using a different email: https://github.com/open-telemetry/opentelemetry-collector-contrib/commit/f517b9e4f6215acb26f66136bfd5c677bc351f70.patch from the one you used here https://github.com/open-telemetry/opentelemetry-collector-contrib/commit/f19ca805ed6b91bf56c73ccbafd114a324a03b0a.patch

Ah, yes, you're right @mx-psi, thanks!

I've recreated this PR in: #30859

Sorry folks!

@albertteoh albertteoh closed this Jan 30, 2024
@albertteoh albertteoh deleted the emeritus-albertteoh branch January 30, 2024 09:29
mx-psi added a commit that referenced this pull request Jan 31, 2024
**Description:** 

Move @albertteoh to emeritus codeowner for both spanmetrics processor
and connector.

Supersedes:
#30815

Signed-off-by: albertteoh <[email protected]>
Co-authored-by: Pablo Baeyens <[email protected]>
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this pull request Feb 1, 2024
…elemetry#30859)

**Description:** 

Move @albertteoh to emeritus codeowner for both spanmetrics processor
and connector.

Supersedes:
open-telemetry#30815

Signed-off-by: albertteoh <[email protected]>
Co-authored-by: Pablo Baeyens <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants