Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][exporter/f5cloud] Fix TestLoadConfig w/ using factory default configs #30759

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

songy23
Copy link
Member

@songy23 songy23 commented Jan 24, 2024

Fixes #30703.

This changes the test to create a otlphttpCfg from factory default, so that the test doesn't fail when new fields are introduced to otlphttp default config.

@TylerHelmuth TylerHelmuth merged commit 409ecbf into open-telemetry:main Jan 24, 2024
86 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 24, 2024
@songy23 songy23 deleted the f5cloud-test branch January 24, 2024 21:17
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this pull request Feb 1, 2024
… configs (open-telemetry#30759)

Fixes
open-telemetry#30703.

This changes the test to create a otlphttpCfg from factory default, so
that the test doesn't fail when new fields are introduced to otlphttp
default config.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter/f5cloud F5 exporter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[exporter/f5cloud] TestLoadConfig failed when new config is introduced to otlphttpexporter
3 participants