Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Update opamp-go to v0.11.0 #30737

Merged
merged 6 commits into from
Jan 24, 2024

Conversation

evan-bradley
Copy link
Contributor

Description:

Update opamp-go to v0.11.0. This version made a breaking change to the logging interface that introduces context, so we now need a bridge between zap.SugaredLogger and the OpAMP types.Logger interface.

Replaces #30721

@github-actions github-actions bot added the cmd/otelcontribcol otelcontribcol command label Jan 23, 2024
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs make gotidy

@mx-psi mx-psi merged commit d5b9920 into open-telemetry:main Jan 24, 2024
85 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 24, 2024
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this pull request Feb 1, 2024
**Description:**

Update opamp-go to v0.11.0. This version made a breaking change to the
logging interface that introduces context, so we now need a bridge
between `zap.SugaredLogger` and the OpAMP `types.Logger` interface.

Replaces
open-telemetry#30721

---------

Co-authored-by: Alex Boten <[email protected]>
anthoai97 pushed a commit to anthoai97/opentelemetry-collector-contrib that referenced this pull request Feb 12, 2024
**Description:**

Update opamp-go to v0.11.0. This version made a breaking change to the
logging interface that introduces context, so we now need a bridge
between `zap.SugaredLogger` and the OpAMP `types.Logger` interface.

Replaces
open-telemetry#30721

---------

Co-authored-by: Alex Boten <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants