[*/datadog] Bump opentelemetry-mapping-go to v0.13.0 #30680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rg v0.11.0 --glob '*.mod' -l | xargs sd '(github.com/DataDog/opentelemetry-mapping-go/.*) v0.11.0' '$1 v0.13.0' make gotidy
mx-psi
force-pushed
the
mx-psi/bump-tov0.12.0
branch
from
dd24e1e
to
8cf7e01
Compare
github-actions
bot
added
cmd/configschema
github-actions
bot
requested review from
dineshg13,
dmitryax,
liustanley,
mackjmr,
pmcollins and
songy23
songy23
approved these changes
Jan 19, 2024
| @@ -4,15 +4,15 @@ go 1.20 | |||
|
|
|||
| require ( | |||
| github.com/DataDog/agent-payload/v5 v5.0.102 | |||
| github.com/DataDog/datadog-agent/pkg/proto v0.50.2 | |||
| github.com/DataDog/datadog-agent/pkg/proto v0.52.0-devel | |||
| github.com/DataDog/datadog-agent/pkg/trace v0.50.2 | |||
There was a problem hiding this comment.
nit: do you want to upgrade this one to v0.52.0-devel too?
There was a problem hiding this comment.
I didn't explicitly bump the other one, it was just because of https://github.com/DataDog/opentelemetry-mapping-go/blob/81d9650bebbbcff44cec39ac97fd9c46420c32bc/pkg/otlp/metrics/go.mod#L6
But it makes sense to bump the rest as well, let me do that
There was a problem hiding this comment.
Looks like this surfaced some problem: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/7585607691/job/20662004468?pr=30680#step:9:166
I'm not sure whether we want to resolve that in this PR or revert the dep upgrade, WDYT?
There was a problem hiding this comment.
I'll revert the bump and open a separate PR for this
mackjmr
approved these changes
Jan 19, 2024
mx-psi
changed the title
This reverts commit 6b4be71.
songy23
approved these changes
Jan 19, 2024
mx-psi
changed the title
mx-psi
removed request for
jpkrohling,
boostchicken,
gouthamve and
MovieStoreGuy
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Feb 1, 2024
…30680) - Bump opentelemetry-mapping-go to v0.13.0 - Amend gohai to adapt to new types - Add changelog note
anthoai97
pushed a commit
to anthoai97/opentelemetry-collector-contrib
that referenced
this pull request
Feb 12, 2024
…30680) - Bump opentelemetry-mapping-go to v0.13.0 - Amend gohai to adapt to new types - Add changelog note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: