Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] move pulsar exporter to generated lifecycle tests #30542

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

Frapschen
Copy link
Contributor

Relates to #27849

lifecycle test can't pass, encounter endless loop:

=== RUN   TestComponentLifecycle
=== RUN   TestComponentLifecycle/logs-shutdown
time="2024-01-13T16:17:22+08:00" level=info msg="[Connecting to broker]" remote_addr="pulsar:https://localhost:6650"
time="2024-01-13T16:17:22+08:00" level=warning msg="[Failed to connect to broker.]" error="dial tcp [::1]:6650: connect: connection refused" remote_addr="pulsar:https://localhost:6650"
time="2024-01-13T16:17:22+08:00" level=info msg="Removed connection from pool key=localhost:665045 0 logical_addr=pulsar:https://localhost:6650 physical_addr=pulsar:https://localhost:6650"
time="2024-01-13T16:17:22+08:00" level=info msg="[Connecting to broker]" remote_addr="pulsar:https://localhost:6650"
time="2024-01-13T16:17:22+08:00" level=warning msg="[Failed to connect to broker.]" error="dial tcp [::1]:6650: connect: connection refused" remote_addr="pulsar:https://localhost:6650"
time="2024-01-13T16:17:23+08:00" level=info msg="Removed connection from pool key=localhost:665045 0 logical_addr=pulsar:https://localhost:6650 physical_addr=pulsar:https://localhost:6650"

@codeboten
Copy link
Contributor

@Frapschen even w/ skip lifecycle tests on it fails? Is this because the initialization of the exporter is trying to establish a connection?

@Frapschen
Copy link
Contributor Author

@Frapschen even w/ skip lifecycle tests on it fails? Is this because the initialization of the exporter is trying to establish a connection?

yes

Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jan 30, 2024
@atoulme
Copy link
Contributor

atoulme commented Jan 31, 2024

Significant changes here. @dmitryax and @dao-jun please review as codeowners, thanks!

@dmitryax dmitryax merged commit 7df40b6 into open-telemetry:main Jan 31, 2024
95 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 31, 2024
@Frapschen Frapschen deleted the pulsar_exporter_lifecycle branch February 1, 2024 01:42
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this pull request Feb 1, 2024
…etry#30542)

Relates to
open-telemetry#27849

lifecycle test can't pass, encounter endless loop:
```
=== RUN   TestComponentLifecycle
=== RUN   TestComponentLifecycle/logs-shutdown
time="2024-01-13T16:17:22+08:00" level=info msg="[Connecting to broker]" remote_addr="pulsar:https://localhost:6650"
time="2024-01-13T16:17:22+08:00" level=warning msg="[Failed to connect to broker.]" error="dial tcp [::1]:6650: connect: connection refused" remote_addr="pulsar:https://localhost:6650"
time="2024-01-13T16:17:22+08:00" level=info msg="Removed connection from pool key=localhost:665045 0 logical_addr=pulsar:https://localhost:6650 physical_addr=pulsar:https://localhost:6650"
time="2024-01-13T16:17:22+08:00" level=info msg="[Connecting to broker]" remote_addr="pulsar:https://localhost:6650"
time="2024-01-13T16:17:22+08:00" level=warning msg="[Failed to connect to broker.]" error="dial tcp [::1]:6650: connect: connection refused" remote_addr="pulsar:https://localhost:6650"
time="2024-01-13T16:17:23+08:00" level=info msg="Removed connection from pool key=localhost:665045 0 logical_addr=pulsar:https://localhost:6650 physical_addr=pulsar:https://localhost:6650"
```

---------

Co-authored-by: Antoine Toulme <[email protected]>
anthoai97 pushed a commit to anthoai97/opentelemetry-collector-contrib that referenced this pull request Feb 12, 2024
…etry#30542)

Relates to
open-telemetry#27849

lifecycle test can't pass, encounter endless loop:
```
=== RUN   TestComponentLifecycle
=== RUN   TestComponentLifecycle/logs-shutdown
time="2024-01-13T16:17:22+08:00" level=info msg="[Connecting to broker]" remote_addr="pulsar:https://localhost:6650"
time="2024-01-13T16:17:22+08:00" level=warning msg="[Failed to connect to broker.]" error="dial tcp [::1]:6650: connect: connection refused" remote_addr="pulsar:https://localhost:6650"
time="2024-01-13T16:17:22+08:00" level=info msg="Removed connection from pool key=localhost:665045 0 logical_addr=pulsar:https://localhost:6650 physical_addr=pulsar:https://localhost:6650"
time="2024-01-13T16:17:22+08:00" level=info msg="[Connecting to broker]" remote_addr="pulsar:https://localhost:6650"
time="2024-01-13T16:17:22+08:00" level=warning msg="[Failed to connect to broker.]" error="dial tcp [::1]:6650: connect: connection refused" remote_addr="pulsar:https://localhost:6650"
time="2024-01-13T16:17:23+08:00" level=info msg="Removed connection from pool key=localhost:665045 0 logical_addr=pulsar:https://localhost:6650 physical_addr=pulsar:https://localhost:6650"
```

---------

Co-authored-by: Antoine Toulme <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants