[chore] move googlecloudpubsub exporter to generated lifecycle tests #30525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatsheep9146
added
the
Skip Changelog
fatsheep9146
approved these changes
Jan 20, 2024
atoulme
force-pushed
the
googlecloudppubsub_exporter_lifecycle
branch
from
49fbc73
to
1c584e9
Compare
|
@alexvanboxel please review as codeowner, thanks! |
fatsheep9146
added
the
ready to merge
codeboten
removed
the
ready to merge
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
@Frapschen can you please rebase? |
atoulme
force-pushed
the
googlecloudppubsub_exporter_lifecycle
branch
2 times, most recently
from
3ed952f
to
f03539b
Compare
atoulme
force-pushed
the
googlecloudppubsub_exporter_lifecycle
branch
from
f03539b
to
c49fdb8
Compare
|
I rebased. |
…cycle' into googlecloudppubsub_exporter_lifecycle # Conflicts: # exporter/googlecloudpubsubexporter/generated_component_test.go # exporter/googlecloudpubsubexporter/go.mod # exporter/googlecloudpubsubexporter/metadata.yaml
# Conflicts: # exporter/googlecloudpubsubexporter/generated_component_test.go # exporter/googlecloudpubsubexporter/go.mod # exporter/googlecloudpubsubexporter/metadata.yaml
fatsheep9146
added
the
ready to merge
This was referenced Mar 19, 2024
|
Is it expected to be no changes in the diff? |
|
I think this was applied through the generalization of tests then. Closing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #27849