Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] move awskinesis exporter to generated lifecycle tests #30512

Merged
merged 2 commits into from
Feb 28, 2024
Merged

[chore] move awskinesis exporter to generated lifecycle tests #30512

merged 2 commits into from
Feb 28, 2024

Conversation

Frapschen
Copy link
Contributor

Relates to #27849

@github-actions GitHub Actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jan 27, 2024
@Frapschen Frapschen removed the Stale label Jan 29, 2024
@atoulme atoulme force-pushed the awskinesis_exporter_lifecyle branch from a522e31 to 6f0feb8 Compare January 31, 2024 22:15
@atoulme
Copy link
Contributor

atoulme commented Jan 31, 2024

Pinging @Aneurysm9 and @MovieStoreGuy for codeowner review

@atoulme atoulme force-pushed the awskinesis_exporter_lifecyle branch 2 times, most recently from 76e5363 to b46324d Compare February 8, 2024 21:45
@github-actions GitHub Actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Feb 23, 2024
@atoulme atoulme added the ready to merge Code review completed; ready to merge by maintainers label Feb 28, 2024
@dmitryax
Copy link
Member

Merging given that it's only an additional test. No functional changes

@dmitryax dmitryax merged commit bd79775 into open-telemetry:main Feb 28, 2024
145 of 147 checks passed
@github-actions github-actions bot added this to the next release milestone Feb 28, 2024
@Frapschen Frapschen deleted the awskinesis_exporter_lifecyle branch March 5, 2024 11:16
XinRanZhAWS pushed a commit to XinRanZhAWS/opentelemetry-collector-contrib that referenced this pull request Mar 13, 2024
@Frapschen @atoulme @XinRanZhAWS
[chore] move awskinesis exporter to generated lifecycle tests (open-t…
c65de9b 
…elemetry#30512)

Relates to open-telemetry#27849

---------

Co-authored-by: Antoine Toulme <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitryax dmitryax dmitryax approved these changes

@MovieStoreGuy MovieStoreGuy MovieStoreGuy approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

Assignees

@dashpole dashpole

Labels
exporter/awskinesis ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Milestone
v0.96.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Frapschen @atoulme @dmitryax @MovieStoreGuy @dashpole