Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add new configuration option in spanmetricsconnector #30436

Merged
merged 2 commits into from
Jan 22, 2024
Merged

docs: add new configuration option in spanmetricsconnector #30436

merged 2 commits into from
Jan 22, 2024

Conversation

rotscher
Copy link
Contributor

Description:

Updated the README of spanmetricsconnector mentioning a new configuration option

@rotscher rotscher requested a review from a team as a code owner January 11, 2024 15:58
@rotscher rotscher requested a review from atoulme January 11, 2024 15:58
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jan 11, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: rotscher / name: Roger Brechbühl (4667bbc)
  • ✅ login: codeboten / name: Alex Boten (4427e8e)

@portertech
Copy link
Contributor

@rotscher wonderful, thank you 👍 seems resource_metrics_key_attributes usage is becoming a necessary/required configuration option.

@portertech
Copy link
Contributor

@fatsheep9146 @atoulme how can I help get this merged?

codeboten
codeboten approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rotscher!

@codeboten codeboten added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 22, 2024
@atoulme
Copy link
Contributor

atoulme commented Jan 22, 2024

@albertteoh should review as codeowner.

albertteoh
albertteoh approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@albertteoh albertteoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@djaglowski djaglowski merged commit b5a90b9 into open-telemetry:main Jan 22, 2024
84 of 85 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 22, 2024
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this pull request Feb 1, 2024
@rotscher @cparkins
docs: add new configuration option in spanmetricsconnector (open-tele…
d63ace2 
…metry#30436)

**Description:** 

Updated the README of spanmetricsconnector mentioning a new
configuration option

Co-authored-by: Alex Boten <[email protected]>
anthoai97 pushed a commit to anthoai97/opentelemetry-collector-contrib that referenced this pull request Feb 12, 2024
@rotscher @anthoai97
docs: add new configuration option in spanmetricsconnector (open-tele…
3b88782 
…metry#30436)

**Description:** 

Updated the README of spanmetricsconnector mentioning a new
configuration option

Co-authored-by: Alex Boten <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@albertteoh albertteoh albertteoh approved these changes

@atoulme atoulme Awaiting requested review from atoulme atoulme is a code owner automatically assigned from open-telemetry/collector-contrib-approvers

@portertech portertech Awaiting requested review from portertech

Assignees

@fatsheep9146 fatsheep9146

Labels
connector/spanmetrics Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
v0.93.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@rotscher @portertech @atoulme @codeboten @albertteoh @djaglowski @fatsheep9146