[chore] move basicauth extension to generated lifecycle tests #30424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b8e5467
to
262f848
Compare
|
Can you please split to keep the git history clean? |
|
#30470 is open to split |
jpkrohling
approved these changes
Jan 25, 2024
cae2477
to
670034e
Compare
frzifus
approved these changes
Feb 1, 2024
TylerHelmuth
approved these changes
Feb 1, 2024
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Feb 1, 2024
…elemetry#30424) Relates to open-telemetry#27849 I have removed code blocking the creation of the extension as Config.Validate does the same checks. --------- Co-authored-by: Tyler Helmuth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #27849
I have removed code blocking the creation of the extension as Config.Validate does the same checks.