Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example config in README #3040

Merged
merged 4 commits into from
Apr 14, 2021

Conversation

albertteoh
Copy link
Contributor

@albertteoh albertteoh commented Apr 11, 2021

Signed-off-by: albertteoh [email protected]

  • Fix '' has invalid keys: pipelines error due to invalid config in README.
  • Add config example to demonstrate a prometheusremotewrite pattern.

Signed-off-by: albertteoh <[email protected]>
@albertteoh albertteoh requested a review from a team as a code owner April 11, 2021 12:39
Signed-off-by: albertteoh <[email protected]>
@codecov
Copy link

codecov bot commented Apr 11, 2021

Codecov Report

Merging #3040 (18f12e0) into main (f1ee616) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3040      +/-   ##
==========================================
+ Coverage   91.56%   91.58%   +0.02%     
==========================================
  Files         466      466              
  Lines       22998    22998              
==========================================
+ Hits        21057    21062       +5     
+ Misses       1445     1441       -4     
+ Partials      496      495       -1     
Flag Coverage Δ
integration 69.02% <ø> (ø)
unit 90.55% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
processor/groupbytraceprocessor/event.go 96.77% <0.00%> (+0.80%) ⬆️
receiver/carbonreceiver/transport/tcp_server.go 67.00% <0.00%> (+1.00%) ⬆️
...rometheusexecreceiver/subprocessmanager/manager.go 76.00% <0.00%> (+6.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1ee616...18f12e0. Read the comment docs.

albertteoh added 2 commits April 12, 2021 05:49
Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a separate PR to add CODEOWNERS entry for this component.

@bogdandrutu bogdandrutu merged commit d3cad09 into open-telemetry:main Apr 14, 2021
pmatyjasek-sumo pushed a commit to pmatyjasek-sumo/opentelemetry-collector-contrib that referenced this pull request Apr 28, 2021
* Fix example config in README

Signed-off-by: albertteoh <[email protected]>

* Add batch processor

Signed-off-by: albertteoh <[email protected]>

* Add example patter for prometheusremotewrite

Signed-off-by: albertteoh <[email protected]>

* Add More Examples

Signed-off-by: albertteoh <[email protected]>
mstumpfx pushed a commit to mstumpfx/opentelemetry-collector-contrib that referenced this pull request Aug 31, 2021
* Fix example config in README

Signed-off-by: albertteoh <[email protected]>

* Add batch processor

Signed-off-by: albertteoh <[email protected]>

* Add example patter for prometheusremotewrite

Signed-off-by: albertteoh <[email protected]>

* Add More Examples

Signed-off-by: albertteoh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants