Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax log converter TestAllConvertedEntriesAreSentAndReceivedWithinAnExpectedTimeDuration conditions #3039

Merged

Conversation

pmalek-sumo
Copy link
Contributor

Description: Fix #3033. Due to flaky nature of asynchronous tests relax time requirements.

Link to tracking Issue: #3033

Testing: Relaxed test conditions

@codecov
Copy link

codecov bot commented Apr 12, 2021

Codecov Report

Merging #3039 (4b48e5f) into main (f1ee616) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3039      +/-   ##
==========================================
- Coverage   91.56%   91.55%   -0.01%     
==========================================
  Files         466      466              
  Lines       22998    22998              
==========================================
- Hits        21057    21056       -1     
  Misses       1445     1445              
- Partials      496      497       +1     
Flag Coverage Δ
integration 68.96% <ø> (-0.07%) ⬇️
unit 90.53% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
receiver/collectdreceiver/receiver.go 68.49% <0.00%> (-2.74%) ⬇️
processor/groupbytraceprocessor/event.go 96.77% <0.00%> (+0.80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1ee616...4b48e5f. Read the comment docs.

@bogdandrutu bogdandrutu merged commit b0e509c into open-telemetry:main Apr 12, 2021
pmatyjasek-sumo pushed a commit to pmatyjasek-sumo/opentelemetry-collector-contrib that referenced this pull request Apr 28, 2021
mstumpfx pushed a commit to mstumpfx/opentelemetry-collector-contrib that referenced this pull request Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestAllConvertedEntriesAreSentAndReceivedWithinAnExpectedTimeDuration is unstable
5 participants