[exporter/awss3] add marsheler config to pick only body content of logs #30318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
anthoai97
force-pushed
the
feat/allow_pick_only_log_body
branch
from
cc69696
to
68f87fc
Compare
|
Please rebase |
anthoai97
force-pushed
the
feat/allow_pick_only_log_body
branch
from
5701888
to
657be70
Compare
@atoulme i'm rebased, thank you !!! |
anthoai97
force-pushed
the
feat/allow_pick_only_log_body
branch
from
657be70
to
afe0686
Compare
atoulme
reviewed
Jan 6, 2024
anthoai97
force-pushed
the
feat/allow_pick_only_log_body
branch
from
afe0686
to
ac36610
Compare
atoulme
reviewed
Jan 8, 2024
atoulme
reviewed
Jan 8, 2024
atoulme
reviewed
Jan 8, 2024
anthoai97
force-pushed
the
feat/allow_pick_only_log_body
branch
from
ac36610
to
63a4451
Compare
atoulme
reviewed
Jan 10, 2024
|
Thank you, this looks good. A last nit on the changelog note and I am ready to accept the PR. |
anthoai97
force-pushed
the
feat/allow_pick_only_log_body
branch
from
63a4451
to
0376f6e
Compare
I'm pleased to hear that. I updated the changelog and changed the variable name to pass the lint workflow. Thank you. |
atoulme
approved these changes
Jan 11, 2024
anthoai97
force-pushed
the
feat/allow_pick_only_log_body
branch
from
45f68bf
to
9ee3f50
Compare
|
Hi @atoulme, could you please guide the steps I need to take to merge into the 'main' branch? Are there any specific requirements or actions I should be aware of? |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
|
Sorry, please rebase and I can flag for maintainers to take a look. |
github-actions
bot
added
cmd/configschema
anthoai97
force-pushed
the
feat/allow_pick_only_log_body
branch
3 times, most recently
from
30fe786
to
c3d8cbd
Compare
|
Dear @atoulme, I have rebased the branch, but unfortunately, I made a mistake during the process which added many reviewers to the review list. Could you please advise me on how to resolve this issue? Thank you very much !!! |
atoulme
removed
Stale
cmd/telemetrygen
atoulme
approved these changes
Feb 12, 2024
anthoai97
force-pushed
the
feat/allow_pick_only_log_body
branch
from
c3d8cbd
to
6a1cdc5
Compare
atoulme
added
the
ready to merge
andrzej-stencel
approved these changes
Feb 13, 2024
XinRanZhAWS
pushed a commit
to XinRanZhAWS/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
…gs (open-telemetry#30318) **Description:** <Describe what has changed.> This pull request introduces a new marshaller for the awss3 exporter. It disregards resources, labels, and selectively extracts only the body content of the logs, facilitating simplified AWS Athena connection and querying. While straightforward, this enhancement accommodates various use cases, enabling the extraction of specific logs for statistical analysis and long-term archival reporting. Example when write only body to S3: ``` EXTERNAL_REQUEST 2023-07-18T10:05:01.976Z GET 200 localhost /organization/v0/properties 0:0:0:0:0:0:0:1 4264 348 wUN0NeTMByHVmIOjo79ImwylAjjkRtkr EXTERNAL_REQUEST 2023-07-18T10:05:01.976Z GET 200 localhost /organization/v0/properties 0:0:0:0:0:0:0:1 4264 348 wUN0NeTMByHVmIOjo79ImwylAjjkRtkr EXTERNAL_REQUEST 2023-07-18T10:05:01.976Z GET 200 localhost /organization/v0/properties 0:0:0:0:0:0:0:1 4264 348 wUN0NeTMByHVmIOjo79ImwylAjjkRtkr EXTERNAL_REQUEST 2023-07-18T10:05:01.976Z GET 200 localhost /organization/v0/properties 0:0:0:0:0:0:0:1 4264 348 wUN0NeTMByHVmIOjo79ImwylAjjkRtkr ``` **Testing:** Work as expected when used Athena to Query: <img width="962" alt="athena" src="https://github.com/open-telemetry/opentelemetry-collector-contrib/assets/85854989/8f682024-df4e-402b-9de1-ee8268ea1936">
nslaughter
pushed a commit
to nslaughter/opentelemetry-collector-contrib
that referenced
this pull request
May 23, 2024
…gs (open-telemetry#30318) **Description:** <Describe what has changed.> This pull request introduces a new marshaller for the awss3 exporter. It disregards resources, labels, and selectively extracts only the body content of the logs, facilitating simplified AWS Athena connection and querying. While straightforward, this enhancement accommodates various use cases, enabling the extraction of specific logs for statistical analysis and long-term archival reporting. Example when write only body to S3: ``` EXTERNAL_REQUEST 2023-07-18T10:05:01.976Z GET 200 localhost /organization/v0/properties 0:0:0:0:0:0:0:1 4264 348 wUN0NeTMByHVmIOjo79ImwylAjjkRtkr EXTERNAL_REQUEST 2023-07-18T10:05:01.976Z GET 200 localhost /organization/v0/properties 0:0:0:0:0:0:0:1 4264 348 wUN0NeTMByHVmIOjo79ImwylAjjkRtkr EXTERNAL_REQUEST 2023-07-18T10:05:01.976Z GET 200 localhost /organization/v0/properties 0:0:0:0:0:0:0:1 4264 348 wUN0NeTMByHVmIOjo79ImwylAjjkRtkr EXTERNAL_REQUEST 2023-07-18T10:05:01.976Z GET 200 localhost /organization/v0/properties 0:0:0:0:0:0:0:1 4264 348 wUN0NeTMByHVmIOjo79ImwylAjjkRtkr ``` **Testing:** Work as expected when used Athena to Query: <img width="962" alt="athena" src="https://github.com/open-telemetry/opentelemetry-collector-contrib/assets/85854989/8f682024-df4e-402b-9de1-ee8268ea1936">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request introduces a new marshaller for the awss3 exporter. It disregards resources, labels, and selectively extracts only the body content of the logs, facilitating simplified AWS Athena connection and querying. While straightforward, this enhancement accommodates various use cases, enabling the extraction of specific logs for statistical analysis and long-term archival reporting.
Example when write only body to S3:
Testing:
Work as expected when used Athena to Query:
Documentation:
Readme updated.