Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/azuremonitor] reduce public api #30224

Merged
merged 6 commits into from
Mar 14, 2024
Merged

[receiver/azuremonitor] reduce public api #30224

merged 6 commits into from
Mar 14, 2024

Conversation

nslaughter
Copy link
Contributor

Description:

Link to tracking Issue:
resolves #24850

Testing:
Does not add tests.

Documentation:
Does not change documentation.

@nslaughter nslaughter requested review from codeboten and a team as code owners December 27, 2023 21:06
@nslaughter nslaughter force-pushed the nslaughter/reduce-public-api-azuremonitorreceiver branch from 9868c9e to 1ae66af Compare December 27, 2023 21:11
@nslaughter
Copy link
Contributor Author

nslaughter commented Dec 28, 2023 •
edited
Loading

I think this qualifies for no-changelog as it's just making some types private. However, I'm also open to making an entry if it's preferred. Made a breaking/api changelog entry calling out the unexported types based on comment of @evan-bradley.

@nslaughter nslaughter mentioned this pull request Dec 28, 2023
Closed
@nslaughter nslaughter changed the title reduce public api [receiver/azuremonitorreceiver] [receiver/azuremonitorreceiver] reduce public api Dec 28, 2023
@nslaughter nslaughter changed the title [receiver/azuremonitorreceiver] reduce public api [receiver/azuremonitor] reduce public api Dec 28, 2023
@nslaughter nslaughter force-pushed the nslaughter/reduce-public-api-azuremonitorreceiver branch from 1ae66af to d6068f1 Compare December 28, 2023 22:17
@evan-bradley
Copy link
Contributor

@nslaughter Could you add a changelog entry with an entry type of api that calls out the removed types? It's highly unlikely anyone is using the API, but technically this is a breaking change for the module.

@github-actions GitHub Actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jan 17, 2024
@github-actions github-actions bot removed the Stale label Jan 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 3, 2024

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Feb 3, 2024
@nslaughter nslaughter mentioned this pull request Feb 14, 2024
Open
@nslaughter nslaughter force-pushed the nslaughter/reduce-public-api-azuremonitorreceiver branch 2 times, most recently from 5755a2e to 27d912e Compare February 14, 2024 21:37
@nslaughter nslaughter force-pushed the nslaughter/reduce-public-api-azuremonitorreceiver branch from 27d912e to 70bb3cc Compare February 14, 2024 21:43
@github-actions github-actions bot removed the Stale label Feb 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Feb 29, 2024
@codeboten codeboten merged commit 860de43 into open-telemetry:main Mar 14, 2024
142 checks passed
@github-actions github-actions bot added this to the next release milestone Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalpristas michalpristas michalpristas left review comments

@codeboten codeboten codeboten approved these changes

@altuner altuner Awaiting requested review from altuner

Assignees

@evan-bradley evan-bradley

Labels
receiver/azuremonitor Stale
Projects
None yet
Milestone
v0.97.0
Development

Successfully merging this pull request may close these issues.

[receiver/azuremonitorreceiver] Consider reducing Go API
4 participants
@nslaughter @evan-bradley @codeboten @michalpristas