[clickhouse/exporter] Fix clickhouse exporter insert metrics data bug #30210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
reviewed
Dec 27, 2023
I updated the Description, you can see it now |
|
@bogdandrutu Please review it |
djaglowski
approved these changes
Jan 17, 2024
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Feb 1, 2024
…open-telemetry#30210) **Description:** <Describe what has changed.> As the insert SQL show: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/66acad234166a2f59347c01b44837a0ca51354e1/exporter/clickhouseexporter/internal/gauge_metrics.go#L70-L77 `traceIDs` and `spanIDs` are in error order in `ExecContext` function: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/66acad234166a2f59347c01b44837a0ca51354e1/exporter/clickhouseexporter/internal/gauge_metrics.go#L129-L133
anthoai97
pushed a commit
to anthoai97/opentelemetry-collector-contrib
that referenced
this pull request
Feb 12, 2024
…open-telemetry#30210) **Description:** <Describe what has changed.> As the insert SQL show: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/66acad234166a2f59347c01b44837a0ca51354e1/exporter/clickhouseexporter/internal/gauge_metrics.go#L70-L77 `traceIDs` and `spanIDs` are in error order in `ExecContext` function: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/66acad234166a2f59347c01b44837a0ca51354e1/exporter/clickhouseexporter/internal/gauge_metrics.go#L129-L133
dmitryax
pushed a commit
that referenced
this pull request
Mar 18, 2024
**Description:** <Describe what has changed.> as #29626 (comment) mentioned, this PR adds an integration test for clickhouse exporter and it brings those benefits: - Verify tables are properly created in clickhouse after any breaking change(filter out bug like [this](#29573) before merge) - Verify if any bugs occur during data insertion like missed data or insert into an error column([30210](#30210)) .etc. - Compatibility testing for `clickhouse-server:23-alpine` and `clickhouse-server:22-alpine` close #29626 --------- Co-authored-by: Tyler Helmuth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
As the insert SQL show:
opentelemetry-collector-contrib/exporter/clickhouseexporter/internal/gauge_metrics.go
Lines 70 to 77 in 66acad2
traceIDsandspanIDsare in error order inExecContextfunction:opentelemetry-collector-contrib/exporter/clickhouseexporter/internal/gauge_metrics.go
Lines 129 to 133 in 66acad2