Fix filelog parser configuration in testbed senders #30018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should I add a changelog entry for this? Kind of a minor change, but maybe it'd be good to have one as reference for the different benchmark results? |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
fatsheep9146
added
Skip Changelog
testbed/datasenders/k8s.go
Outdated
| @@ -238,6 +241,7 @@ func NewKubernetesCRIContainerdWriter() *FileLogK8sWriter { | |||
| id: parser-containerd | |||
| regex: '^(?P<time>[^ ^Z]+Z) (?P<stream>stdout|stderr) (?P<logtag>[^ ]*) (?P<log>.*)$' | |||
| output: extract_metadata_from_filepath | |||
| parse_to: body | |||
There was a problem hiding this comment.
I run the test locally and found kubernetes containers test case does not file error as you posts, only filelog and filelog checkpoints has parse errors, I think the change in stanza.go already fix these two.
So what is the change in k8s.go for?
There was a problem hiding this comment.
It was fixed in #30301 so it's not necessary anymore. I've removed it.
There was a problem hiding this comment.
It was fixed in #30301 so it's not necessary anymore. I've removed it.
Thanks!
|
Here is the agent.log for |
swiatekm
force-pushed
the
fix/testbed/log-parsers
branch
from
bce615b
to
bad855c
Compare
fatsheep9146
approved these changes
Jan 10, 2024
fatsheep9146
added
the
ready to merge
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Jan 10, 2024
…0018) **Description:** Filelog senders in testbed have incorrect parsing configurations, leading to lots of parse errors: ``` 2023-12-16T18:19:53.515+0100 error helper/transformer.go:98 Failed to process entry {"kind": "receiver", "name": "filelog", "data_type": "logs", "operator_id": "regex_parser", "operator_type": "regex_parser", "error": {"description": "time parser: log entry does not have the expected parse_from field", "suggestion": "ensure that all entries forwarded to this parser contain the parse_from field", "details": {"parse_from": "body.time"}}, "action": "send", "entry": {"observed_timestamp":"2023-12-16T18:19:53.515753831+01:00","timestamp":"0001-01-01T00:00:00Z","body":"2023-12-16 INFO3 Load Generator Counter #0 batch_index=batch_1 item_index=item_1 a=test b=5 c=3 d=true","attributes":{"log.file.name":"perf-logs.log2985945617","msg":"Load Generator Counter #0 batch_index=batch_1 item_index=item_1 a=test b=5 c=3 d=true","sev":"INFO3","time":"2023-12-16"},"severity":0,"scope_name":""}} ``` This change fixes the errors. Note that there's going to be a change in benchmark results, as right now the error handling methods figure prominently in the benchmark. While it's not invalid to benchmark these, in general I think we'd prefer to check the happy path instead. **Testing:** Reran the testbed tests, saw no errors in agent logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Filelog senders in testbed have incorrect parsing configurations, leading to lots of parse errors:
This change fixes the errors.
Note that there's going to be a change in benchmark results, as right now the error handling methods figure prominently in the benchmark. While it's not invalid to benchmark these, in general I think we'd prefer to check the happy path instead.
Testing:
Reran the testbed tests, saw no errors in agent logs.