[chore] refactore carbonexporter to handle errors, use generic interfaces #29885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
commented
Dec 14, 2023
| @@ -109,6 +99,18 @@ func (cp *connPool) Write(bytes []byte) (int, error) { | |||
| } | |||
| } | |||
|
|
|||
| // The deferred function below is what puts back connections on the pool if no error. | |||
| defer func() { | |||
There was a problem hiding this comment.
Simplify logic, conn cannot be nil
atoulme
reviewed
Dec 14, 2023
bogdandrutu
force-pushed
the
carbonexporter-refactor
branch
from
904321a
to
26a82cb
Compare
…aces Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
carbonexporter-refactor
branch
from
26a82cb
to
4122d13
Compare
dmitryax
approved these changes
Dec 15, 2023
nslaughter
pushed a commit
to nslaughter/opentelemetry-collector-contrib
that referenced
this pull request
Dec 27, 2023
…aces (open-telemetry#29885) Signed-off-by: Bogdan Drutu <[email protected]>
nslaughter
pushed a commit
to nslaughter/opentelemetry-collector-contrib
that referenced
this pull request
Dec 27, 2023
…aces (open-telemetry#29885) Signed-off-by: Bogdan Drutu <[email protected]>
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Jan 10, 2024
…aces (open-telemetry#29885) Signed-off-by: Bogdan Drutu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.