[chore] add warning documentation around healthcheck extension #29782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows open-telemetry/opentelemetry-collector#9065 (comment) Signed-off-by: Alex Boten <[email protected]>
TylerHelmuth
approved these changes
Dec 12, 2023
mx-psi
approved these changes
Dec 12, 2023
mx-psi
reviewed
Dec 12, 2023
IMO let's deprecate it once we are closer to having a replacement, the extension is still useful in some basic cases and we don't have a replacement yet |
Co-authored-by: Pablo Baeyens <[email protected]>
either that or the new healthcheck extension may be able to guarantee backwards compatibility with the functionality we know works for this extension (the basic case), and then we don't need to migrate anything |
crobert-1
approved these changes
Dec 12, 2023
codeboten
added a commit
that referenced
this pull request
Jun 11, 2024
This PR removes the dependency on opencensus by removing the code that sets up a view to trigger healthcheck status changes. This functionality does not work as documented in the README: https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/extension/healthcheckextension#health-check I'm proposing to remove the code that brings an unnecessary dependency for functionality that isn't working. Fixes #33469 As discussed previously #29782, an improved functionality will be implemented in the v2 healthcheck extension --------- Signed-off-by: Alex Boten <[email protected]>
t00mas
pushed a commit
to t00mas/opentelemetry-collector-contrib
that referenced
this pull request
Jun 18, 2024
This PR removes the dependency on opencensus by removing the code that sets up a view to trigger healthcheck status changes. This functionality does not work as documented in the README: https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/extension/healthcheckextension#health-check I'm proposing to remove the code that brings an unnecessary dependency for functionality that isn't working. Fixes open-telemetry#33469 As discussed previously open-telemetry#29782, an improved functionality will be implemented in the v2 healthcheck extension --------- Signed-off-by: Alex Boten <[email protected]>
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Jul 11, 2024
This PR removes the dependency on opencensus by removing the code that sets up a view to trigger healthcheck status changes. This functionality does not work as documented in the README: https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/extension/healthcheckextension#health-check I'm proposing to remove the code that brings an unnecessary dependency for functionality that isn't working. Fixes open-telemetry#33469 As discussed previously open-telemetry#29782, an improved functionality will be implemented in the v2 healthcheck extension --------- Signed-off-by: Alex Boten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows open-telemetry/opentelemetry-collector#9065 (comment)