Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation of resource_attributes_as_tags #29765

Conversation

mackjmr
Copy link
Member

@mackjmr mackjmr commented Dec 12, 2023

Description:
This PR improves documentation of resource_attributes_as_tags.

Link to tracking Issue:
Closes #29702

Testing:

Documentation:

@mackjmr mackjmr requested review from mx-psi, songy23 and a team as code owners December 12, 2023 10:52
@github-actions github-actions bot added the exporter/datadog Datadog components label Dec 12, 2023
@mx-psi mx-psi added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Dec 12, 2023
@mx-psi mx-psi merged commit 71f8146 into open-telemetry:main Dec 12, 2023
88 of 89 checks passed
@github-actions github-actions bot added this to the next release milestone Dec 12, 2023
@ringerc
Copy link

ringerc commented Dec 13, 2023

Thanks. The docs link should be significantly helpful.

It wouldn't hurt to have an example too, say

For example, host.name will always be mapped to datadog tag "host" by the exporter and service.name will be mapped to datadog tag "service". If this setting is "true", the original "host.name" and "service.name" tags will ALSO be retained and sent verbatim to datadog.

Consider warning the customer about the impact of this on DD billing by linking to the custom metrics billing docs page. Enabling this setting without careful filtering of resource attributes could result in bill shock.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter/datadog Datadog components Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

datadog: document resource_attributes_as_tags behaviour and tag mapping, link to docs for actual mappings
3 participants