K8s processor metrics refactor: #2971
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* replace slashes(/) with underscores(_) * rename otelsvc prefix for otelcol * rename lookup miss metric to fit for new mechanism * add metrics description to doc Signed-off-by: Patryk Matyjasek <[email protected]>
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
Please make sure the build passes. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Signed-off-by: Patryk Matyjasek <[email protected]>
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
otel settled on .'s in metric names: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/semantic_conventions/README.md (Granted this hasn't been updated consistently throughout yet..) |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
punya
pushed a commit
to punya/opentelemetry-collector-contrib
that referenced
this pull request
Jul 21, 2021
…etry#2971) Signed-off-by: Bogdan Drutu <[email protected]>
punya
pushed a commit
to punya/opentelemetry-collector-contrib
that referenced
this pull request
Jul 21, 2021
…etry#2971) Signed-off-by: Bogdan Drutu <[email protected]>
alexperez52
referenced
this pull request
in open-o11y/opentelemetry-collector-contrib
Aug 18, 2021
Signed-off-by: Bogdan Drutu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
K8s processor metrics refactor:
Signed-off-by: Patryk Matyjasek [email protected]
Link to tracking Issue:
#2322
Testing:
Unit tests
Documentation:
doc.go file update