[exporter/azuremonitor] Fix: Correct Placement of Span Attributes in AzureMonitorExporter #29684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajkumar-rangaraj
changed the title
pcwiese
reviewed
Dec 8, 2023
.chloggen/azuremonitorexporter-fix-span-attributes-in-properties.yaml
Outdated
Show resolved
Hide resolved
pcwiese
approved these changes
Dec 8, 2023
|
@open-telemetry/collector-contrib-approvers Could you please help merge this PR, got an approval from the code owner. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
fatsheep9146
approved these changes
Dec 26, 2023
fatsheep9146
added
ready to merge
88 tasks
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Jan 10, 2024
…AzureMonitorExporter (open-telemetry#29684) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> This pull request addresses an issue in the Azure Monitor exporter where span attributes with double and int values were incorrectly added to the `measurements` field instead of the `properties` field in the Application Insights schema. **Changes** - Modified the AzureMonitorExporter to ensure that span attributes of type double and int are correctly placed in the properties field. - Manual testing was conducted to verify that the span attributes appear correctly in the properties field. **Link to tracking Issue:** <Issue number if applicable> open-telemetry#29683 **Testing:** <Describe what testing was performed and which tests were added.> - Updated relevant tests to reflect this change and ensure correctness.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request addresses an issue in the Azure Monitor exporter where span attributes with double and int values were incorrectly added to the
measurementsfield instead of thepropertiesfield in the Application Insights schema.Changes
Link to tracking Issue: #29683
Testing: