Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pkg/stanza] Fix issue where files were unnecessarily kept open on windows #29514

Merged
merged 1 commit into from
Nov 28, 2023
Merged

[pkg/stanza] Fix issue where files were unnecessarily kept open on windows #29514

merged 1 commit into from
Nov 28, 2023

Conversation

djaglowski
Copy link
Member

Resolves #29149

@djaglowski djaglowski added the Run Windows Enable running windows test on a PR label Nov 27, 2023
@djaglowski djaglowski mentioned this pull request Nov 27, 2023
Closed
@djaglowski djaglowski force-pushed the fileconsumer-fix-windows branch 3 times, most recently from fc668dc to 917159a Compare November 27, 2023 21:06
@djaglowski djaglowski marked this pull request as ready for review November 27, 2023 22:58
@djaglowski djaglowski requested a review from a team as a code owner November 27, 2023 22:58
@codeboten codeboten merged commit b8100ca into open-telemetry:main Nov 28, 2023
93 checks passed
@github-actions github-actions bot added this to the next release milestone Nov 28, 2023
@djaglowski djaglowski deleted the fileconsumer-fix-windows branch November 28, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu bogdandrutu is a code owner automatically assigned from open-telemetry/collector-contrib-approvers

Assignees

@codeboten codeboten

Labels
pkg/stanza Run Windows Enable running windows test on a PR
Projects
None yet
Milestone
v0.90.0
Development

Successfully merging this pull request may close these issues.

Windows collector locks docker logs and prevent docker for removing containers
2 participants
@djaglowski @codeboten