Update core to latest, fix breaking change adding the Validate func on config #2950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n config Signed-off-by: Bogdan Drutu <[email protected]>
dmitryax
approved these changes
Mar 31, 2021
Codecov Report
@@ Coverage Diff @@
## main #2950 +/- ##
==========================================
- Coverage 91.56% 91.55% -0.01%
==========================================
Files 463 464 +1
Lines 22858 22860 +2
==========================================
Hits 20929 20929
- Misses 1436 1438 +2
Partials 493 493
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
pmatyjasek-sumo
pushed a commit
to pmatyjasek-sumo/opentelemetry-collector-contrib
that referenced
this pull request
Apr 28, 2021
…n config (open-telemetry#2950) Signed-off-by: Bogdan Drutu <[email protected]>
alexperez52
referenced
this pull request
in open-o11y/opentelemetry-collector-contrib
Aug 18, 2021
k8s_tagger relies on the context.Context object to find the pod IP of the incoming telemetry. This context gets lost when batch processor is hit. Adding recommendation here even though k8s_tagger is a contrib to because this is where ordering recommendations are made and it's a common processor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bogdan Drutu [email protected]