[chore] Update directions on adding a Code Owner #29451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main change here is to add the step to directions of updating a component's metadata.yaml file, in addition to the CODEOWNERS file. Since I was changing this I decided to make some formatting changes while I was here.
crobert-1
force-pushed
the
codeownership_update
branch
from
1341b9a
to
b0b4d17
Compare
RoryCrispin
pushed a commit
to ClickHouse/opentelemetry-collector-contrib
that referenced
this pull request
Nov 24, 2023
The main change here is to add the step to directions of updating a component's `metadata.yaml` file, and removing the directions to update the CODEOWNERS file (since it's auto-generated now). Since I was changing this I decided to make some formatting changes while I was here.
codeboten
pushed a commit
that referenced
this pull request
Nov 27, 2023
In my [last update](#29451) I incorrectly removed a note about adding your username to the `.github/CODEOWNERS` file. I assumed it would be done automatically since the file has a header saying it's generated automatically, but I was incorrect. The file is generated by the `make gengithub` command which is run by users, not a GitHub workflow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation:
The main change here is to add the step to directions of updating a component's
metadata.yamlfile, and removing the directions to update the CODEOWNERS file (since it's auto-generated now). Since I was changing this I decided to make some formatting changes while I was here.