[chore] testbed: sending queue otlp #28904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
reviewed
Nov 13, 2023
testbed/testbed/test_case.go
Outdated
| @@ -322,3 +324,35 @@ func (tc *TestCase) logStatsOnce() { | |||
| tc.LoadGenerator.GetStats(), | |||
| tc.MockBackend.GetStats()) | |||
| } | |||
|
|
|||
| // Used to search for text in agent.log | |||
| // It can be used to verify if we've hit QueuedRetry sender or memory limitter | |||
There was a problem hiding this comment.
Suggested change
| // It can be used to verify if we've hit QueuedRetry sender or memory limitter | |
| // It can be used to verify if we've hit QueuedRetry sender or memory limiter |
atoulme
reviewed
Nov 13, 2023
testbed/testbed/test_case.go
Outdated
|
|
||
| // Used to search for text in agent.log | ||
| // It can be used to verify if we've hit QueuedRetry sender or memory limitter | ||
| func (tc *TestCase) SearchText(text string) bool { |
There was a problem hiding this comment.
Suggested change
| func (tc *TestCase) SearchText(text string) bool { | |
| func (tc *TestCase) AgentLogsContains(text string) bool { |
1bdcc75
to
34ce8e7
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Hey @mx-psi, can you take a look? 🥺 |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
mx-psi
reviewed
Dec 22, 2023
There was a problem hiding this comment.
Hey, sorry I didn't get to this sooner 😅 I won't be active over the holidays, but can review when I am back. I merged main into your PR and it looks like there are a few linting errors.
Would also want @atoulme to have a look as well at this before merging
…etry-collector-contrib into test/sending-queue-otlp
mx-psi
approved these changes
Jan 4, 2024
atoulme
approved these changes
Jan 4, 2024
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Jan 10, 2024
**Description:** This PR adds two tests with an otlp receiver and exporter with sending queues. We have two scenarios here: Sending queue full 1. We generate permanent errors until `sending_queue is full` log appears in the agent's logs 2. Then we get IDs of logs meant to be retried and IDs of logs received successfully and check if all of them were retried The current testbed is unable to get the information about the errors from load generator's perspective, so I needed to put `LogsToRetry` in `mock_backend` to be able to track what logs suffered from permanent error. Sending queue not full Sanity test to check a default behavior of sending queue, but without making it full. So far only logs sending queues are covered, not sure if we should add it for every data type. Currently, one test takes about ~9s. **Link to tracking Issue:** A related issue is this one: open-telemetry#20552, as these tests cover `Exporter helper QueuedRetry queue limit size is hit.` scenario --------- Co-authored-by: Pablo Baeyens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This PR adds two tests with an otlp receiver and exporter with sending queues. We have two scenarios here:
Sending queue full
sending_queue is fulllog appears in the agent's logsThe current testbed is unable to get the information about the errors from load generator's perspective, so I needed to put
LogsToRetryinmock_backendto be able to track what logs suffered from permanent error.Sending queue not full
Sanity test to check a default behavior of sending queue, but without making it full.
So far only logs sending queues are covered, not sure if we should add it for every data type. Currently, one test takes about ~9s.
Link to tracking Issue: A related issue is this one: #20552, as these tests cover
Exporter helper QueuedRetry queue limit size is hit.scenario