-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First PR - Failover Connector skeleton #28818
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @akats7.
I've done a cursory review of the boilerplate files. I'll circle back to the actual code included in the PR shortly.
I noted a couple nits, and we need some additional boilerplate changes as well:
- Please run
make chlog-new
and fill in the generate changelog file. - Please run
make gendependabot
to updatedependabot.yaml
- Please add the component to
.github/CODEOWNERS
. Typically you and I would be owners for the component but you'll have to become a member of the OTel org to do so. For now, please just add me and plan on applying once we've merged a few PRs for this component.
Just a housekeeping item: Can remove the word Including the word |
Ah right, good call |
failed checks should be fixed @akats7 |
Hi @fatsheep9146, I believe they should all be resolved, looks like theres something going on with govulncheck in the rest of the pipeline |
Hey @djaglowski, I believe everything has been addressed. |
yes, the failed test seems related to #29109 |
I suggest we wait for #29109 merged, and the rebase this pr again, since some checks are skipped due to this problem. |
Hi @djaglowski @fatsheep9146, all checks are passing |
I've tagged this as ready to merge but will hold off while contrib release is in progress. |
This is the Part 1 PR for the Failover Connector (split according to the CONTRIBUTING.md doc) Link to tracking Issue: open-telemetry#20766 Testing: Added factory test Note: Full functionality PR exists [here](open-telemetry#27641) and will likely be refactored to serve as the part 2 PR cc: @djaglowski @sethallen @MovieStoreGuy
This is the Part 1 PR for the Failover Connector (split according to the CONTRIBUTING.md doc)
Link to tracking Issue: #20766
Testing: Added factory test
Note: Full functionality PR exists here and will likely be refactored to serve as the part 2 PR
cc: @djaglowski @sethallen @MovieStoreGuy