Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Spanmetrics] - Add exemplars to Sum metrics #28671

Merged
merged 3 commits into from
Nov 1, 2023
Merged

[Spanmetrics] - Add exemplars to Sum metrics #28671

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
582a9a5
Resolve conflicts in connector_test.go
aishyandapalli Oct 31, 2023
aa9686c
add to .chloggen
aishyandapalli Oct 27, 2023
8969b1d
use assert.greater
aishyandapalli Oct 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
use assert.greater
  • Loading branch information
@aishyandapalli
aishyandapalli committed Oct 31, 2023
commit 8969b1d3f8b103356dd44d3e80ff104d3f2babb9
2 changes: 1 addition & 1 deletion connector/spanmetricsconnector/connector_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1342,7 +1342,7 @@ func TestExemplarsForSumMetrics(t *testing.T) {
dps := metric.Sum().DataPoints()
for dpi := 0; dpi < dps.Len(); dpi++ {
dp := dps.At(dpi)
assert.True(t, dp.Exemplars().Len() > 0)
assert.Greater(t, dp.Exemplars().Len(), 0)
}
}
}
Expand Down