Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore][processor/resourcedetection] Fix dead links in README #28669

Merged
merged 1 commit into from
Oct 27, 2023
Merged

[chore][processor/resourcedetection] Fix dead links in README #28669

merged 1 commit into from
Oct 27, 2023

Conversation

crobert-1
Copy link
Member

@crobert-1 crobert-1 commented Oct 27, 2023 •
edited
Loading

Description:

There are a number of links in the resource detection processor's README that are pointing to the old spec repo. This was causing check-links to fail.

@crobert-1 crobert-1 requested review from Aneurysm9, dashpole and a team as code owners October 27, 2023 16:03
@crobert-1 crobert-1 changed the title [chore][processor/resourcedetection] Fix dead links README [chore][processor/resourcedetection] Fix dead links in README Oct 27, 2023
@crobert-1 crobert-1 added documentation Improvements or additions to documentation processor/resourcedetection Resource detection processor labels Oct 27, 2023
@crobert-1 crobert-1 mentioned this pull request Oct 27, 2023
Merged
songy23
songy23 approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@codeboten codeboten added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Oct 27, 2023
@codeboten codeboten merged commit 511b04b into open-telemetry:main Oct 27, 2023
95 of 96 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 27, 2023
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
@crobert-1 @jmsnll
[chore][processor/resourcedetection] Fix dead links in README (open-t…
b2f5649 
…elemetry#28669)

There are a number of links in the resource detection processor's README
that are pointing to the old spec repo. This was causing `check-links`
to fail.
RoryCrispin pushed a commit to ClickHouse/opentelemetry-collector-contrib that referenced this pull request Nov 24, 2023
@crobert-1 @RoryCrispin
[chore][processor/resourcedetection] Fix dead links in README (open-t…
422557d 
…elemetry#28669)

There are a number of links in the resource detection processor's README
that are pointing to the old spec repo. This was causing `check-links`
to fail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@dmitryax dmitryax dmitryax approved these changes

@songy23 songy23 songy23 approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

Assignees

@MovieStoreGuy MovieStoreGuy

Labels
documentation Improvements or additions to documentation processor/resourcedetection Resource detection processor Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
v0.90.0
Development

Successfully merging this pull request may close these issues.
5 participants
@crobert-1 @codeboten @dmitryax @songy23 @MovieStoreGuy