-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[processor/k8sattribute] support adding labels and annotations from node #28570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haoqixu
requested review from
dmitryax,
fatsheep9146,
TylerHelmuth and
a team
as code owners
October 25, 2023 08:49
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see anything big on a first path through. Great job seamlessly incorporating this capability.
Co-authored-by: Tyler Helmuth <[email protected]>
Co-authored-by: Tyler Helmuth <[email protected]>
Co-authored-by: Tyler Helmuth <[email protected]>
TylerHelmuth
approved these changes
Oct 25, 2023
dmitryax
approved these changes
Oct 31, 2023
6 tasks
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
…ode (open-telemetry#28570) **Description:** support adding labels and annotations from the node as additional resource attributes on telemetry processed through the `k8sattributes` processor. **Link to tracking Issue:** Resolve open-telemetry#22620 --------- Co-authored-by: Tyler Helmuth <[email protected]>
RoryCrispin
pushed a commit
to ClickHouse/opentelemetry-collector-contrib
that referenced
this pull request
Nov 24, 2023
…ode (open-telemetry#28570) **Description:** support adding labels and annotations from the node as additional resource attributes on telemetry processed through the `k8sattributes` processor. **Link to tracking Issue:** Resolve open-telemetry#22620 --------- Co-authored-by: Tyler Helmuth <[email protected]>
4 tasks
dmitryax
added a commit
that referenced
this pull request
Aug 1, 2024
Annotations and labels extraction is possible from nodes as well after #28570. Fixing a missing doc string
dmitryax
added a commit
that referenced
this pull request
Aug 1, 2024
Annotations and labels extraction is possible from nodes as well after #28570. Fixing a missing doc string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
support adding labels and annotations from the node as additional resource attributes on telemetry processed through the
k8sattributes
processor.Link to tracking Issue:
Resolve #22620
Testing:
Documentation: