Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processor/k8sattribute] support adding labels and annotations from node #28570

Merged
merged 15 commits into from
Oct 31, 2023

Conversation

haoqixu
Copy link
Member

@haoqixu haoqixu commented Oct 24, 2023

Description:
support adding labels and annotations from the node as additional resource attributes on telemetry processed through the k8sattributes processor.

Link to tracking Issue:
Resolve #22620

Testing:

Documentation:

@github-actions github-actions bot added the processor/k8sattributes k8s Attributes processor label Oct 24, 2023
@haoqixu haoqixu marked this pull request as ready for review October 25, 2023 08:49
Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything big on a first path through. Great job seamlessly incorporating this capability.

processor/k8sattributesprocessor/README.md Outdated Show resolved Hide resolved
processor/k8sattributesprocessor/README.md Outdated Show resolved Hide resolved
processor/k8sattributesprocessor/README.md Outdated Show resolved Hide resolved
processor/k8sattributesprocessor/options.go Outdated Show resolved Hide resolved
@dmitryax dmitryax merged commit 49438fe into open-telemetry:main Oct 31, 2023
83 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 31, 2023
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
…ode (open-telemetry#28570)

**Description:**
support adding labels and annotations from the node as additional
resource attributes on telemetry processed through the `k8sattributes`
processor.

**Link to tracking Issue:** Resolve  open-telemetry#22620

---------

Co-authored-by: Tyler Helmuth <[email protected]>
RoryCrispin pushed a commit to ClickHouse/opentelemetry-collector-contrib that referenced this pull request Nov 24, 2023
…ode (open-telemetry#28570)

**Description:**
support adding labels and annotations from the node as additional
resource attributes on telemetry processed through the `k8sattributes`
processor.

**Link to tracking Issue:** Resolve  open-telemetry#22620

---------

Co-authored-by: Tyler Helmuth <[email protected]>
dmitryax added a commit that referenced this pull request Aug 1, 2024
Annotations and labels extraction is possible from nodes as well after #28570. Fixing a missing doc string
dmitryax added a commit that referenced this pull request Aug 1, 2024
Annotations and labels extraction is possible from nodes as well after
#28570.
Fixing a missing doc string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
processor/k8sattributes k8s Attributes processor
Projects
None yet
4 participants