[chore][pkg/stanza] Fix tests which leave files open #28569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaglowski
force-pushed
the
pkg-stanza-fix-win-files
branch
3 times, most recently
from
bff0641
to
fb326b1
Compare
atoulme
reviewed
Oct 24, 2023
djaglowski
force-pushed
the
pkg-stanza-fix-win-files
branch
from
fb326b1
to
70f0927
Compare
djaglowski
force-pushed
the
pkg-stanza-fix-win-files
branch
from
70f0927
to
6bb6c96
Compare
pjanotti
approved these changes
Oct 24, 2023
songy23
approved these changes
Oct 24, 2023
dmitryax
approved these changes
Oct 24, 2023
sigilioso
pushed a commit
to carlossscastro/opentelemetry-collector-contrib
that referenced
this pull request
Oct 27, 2023
…28569) `fileconsumer.Manager.poll` leaves files open so that the next poll cycle can use them. In tests, the direct use of this function should be accompanied by explicit action to clean up the files.
povilasv
pushed a commit
to coralogix/opentelemetry-collector-contrib
that referenced
this pull request
Nov 8, 2023
…28569) `fileconsumer.Manager.poll` leaves files open so that the next poll cycle can use them. In tests, the direct use of this function should be accompanied by explicit action to clean up the files.
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
…28569) `fileconsumer.Manager.poll` leaves files open so that the next poll cycle can use them. In tests, the direct use of this function should be accompanied by explicit action to clean up the files.
RoryCrispin
pushed a commit
to ClickHouse/opentelemetry-collector-contrib
that referenced
this pull request
Nov 24, 2023
…28569) `fileconsumer.Manager.poll` leaves files open so that the next poll cycle can use them. In tests, the direct use of this function should be accompanied by explicit action to clean up the files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fileconsumer.Manager.pollleaves files open so that the next poll cycle can use them. In tests, the direct use of this function should be accompanied by explicit action to clean up the files.