Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][exporter/datadog] Add integration tests #28396

Merged
merged 10 commits into from
Oct 26, 2023

Conversation

songy23
Copy link
Member

@songy23 songy23 commented Oct 23, 2023

Description:

Add an integration tests to datadog exporter that:

  1. Use the mock server in datadog exporter testutil as the backend
  2. Starts a collector with otlp receiver, datadog connector, tail sampling processor, datadog exporter. Have datadog exporter send data to the mock server
  3. Generate and send 10 spans to collector, 5 of which are expected to be sampled by tail sampling processor
  4. Verify the mock server receives 5 traces (sampled) + APM stats on all 10 traces pre-sampled

Link to tracking Issue:

Testing:

Documentation:

@songy23 songy23 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Oct 23, 2023
@songy23 songy23 requested review from mx-psi and a team as code owners October 23, 2023 19:46
@github-actions github-actions bot added the exporter/datadog Datadog components label Oct 23, 2023
@songy23
Copy link
Member Author

songy23 commented Oct 24, 2023

https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/6626465958/job/17999616412?pr=28396

Weird, I cannot reproduce the test failure in my local runs. #28582 should address it.

Convert to draft for now

@songy23 songy23 marked this pull request as draft October 24, 2023 12:24
@mx-psi mx-psi merged commit fd9efcf into open-telemetry:main Oct 26, 2023
85 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 26, 2023
@songy23 songy23 deleted the dd-test branch October 26, 2023 13:29
sigilioso pushed a commit to carlossscastro/opentelemetry-collector-contrib that referenced this pull request Oct 27, 2023
**Description:** <Describe what has changed.>

Add an integration tests to datadog exporter that:
1. Use the mock server in datadog exporter testutil as the backend
2. Starts a collector with otlp receiver, datadog connector, tail
sampling processor, datadog exporter. Have datadog exporter send data to
the mock server
3. Generate and send 10 spans to collector, 5 of which are expected to
be sampled by tail sampling processor
4. Verify the mock server receives 5 traces (sampled) + APM stats on all
10 traces pre-sampled

**Link to tracking Issue:** <Issue number if applicable>

**Testing:** <Describe what testing was performed and which tests were
added.>

**Documentation:** <Describe the documentation added.>
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
**Description:** <Describe what has changed.>

Add an integration tests to datadog exporter that:
1. Use the mock server in datadog exporter testutil as the backend
2. Starts a collector with otlp receiver, datadog connector, tail
sampling processor, datadog exporter. Have datadog exporter send data to
the mock server
3. Generate and send 10 spans to collector, 5 of which are expected to
be sampled by tail sampling processor
4. Verify the mock server receives 5 traces (sampled) + APM stats on all
10 traces pre-sampled

**Link to tracking Issue:** <Issue number if applicable>

**Testing:** <Describe what testing was performed and which tests were
added.>

**Documentation:** <Describe the documentation added.>
RoryCrispin pushed a commit to ClickHouse/opentelemetry-collector-contrib that referenced this pull request Nov 24, 2023
**Description:** <Describe what has changed.>

Add an integration tests to datadog exporter that:
1. Use the mock server in datadog exporter testutil as the backend
2. Starts a collector with otlp receiver, datadog connector, tail
sampling processor, datadog exporter. Have datadog exporter send data to
the mock server
3. Generate and send 10 spans to collector, 5 of which are expected to
be sampled by tail sampling processor
4. Verify the mock server receives 5 traces (sampled) + APM stats on all
10 traces pre-sampled

**Link to tracking Issue:** <Issue number if applicable>

**Testing:** <Describe what testing was performed and which tests were
added.>

**Documentation:** <Describe the documentation added.>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter/datadog Datadog components Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants