Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] make the collector module version script output a git diff #27898

Merged
merged 3 commits into from
Oct 27, 2023

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Oct 20, 2023

The current behavior consists in exiting early on the first difference found.

This approach continues to look at all changes, and only exits after outputting a git diff of all the changes.

@atoulme
Copy link
Contributor Author

atoulme commented Oct 20, 2023

This will allow possibly users down the road to perform this task on their laptop with a make target, so they can easily fix this type of issues.

Copy link
Contributor

@MovieStoreGuy MovieStoreGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes senes to me, but I wouldn't mind if @codeboten or @djaglowski since i know they have spent some time setting up the CI.

@codeboten
Copy link
Contributor

This will allow possibly users down the road to perform this task on their laptop with a make target, so they can easily fix this type of issues.

FYI: on a mac, the following error message shows when I run the command:

sed: 1: "./cmd/mdatagen/go.mod": invalid command code .

This is because sed in macos is slightly different https://stackoverflow.com/questions/19456518/error-when-using-sed-with-find-command-on-os-x-invalid-command-code

@atoulme
Copy link
Contributor Author

atoulme commented Oct 25, 2023

I can fix it to make it work on Mac, IIRC when I did that it broke on Linux. I'll keep trying.

@MovieStoreGuy MovieStoreGuy merged commit a23ae4b into open-telemetry:main Oct 27, 2023
83 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 27, 2023
sigilioso pushed a commit to carlossscastro/opentelemetry-collector-contrib that referenced this pull request Oct 27, 2023
…pen-telemetry#27898)

The current behavior consists in exiting early on the first difference
found.

This approach continues to look at all changes, and only exits after
outputting a git diff of all the changes.
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
…pen-telemetry#27898)

The current behavior consists in exiting early on the first difference
found.

This approach continues to look at all changes, and only exits after
outputting a git diff of all the changes.
RoryCrispin pushed a commit to ClickHouse/opentelemetry-collector-contrib that referenced this pull request Nov 24, 2023
…pen-telemetry#27898)

The current behavior consists in exiting early on the first difference
found.

This approach continues to look at all changes, and only exits after
outputting a git diff of all the changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants