[pkg/ottl] Add status header to readme #27896
Conversation
TylerHelmuth
requested review from
bogdandrutu,
evan-bradley and
a team
as code owners
TylerHelmuth
added
the
Skip Changelog
pkg/ottl/README.md
Outdated
| @@ -1,5 +1,13 @@ | |||
| # OpenTelemetry Transformation Language | |||
|
|
|||
| | Status | | | |||
There was a problem hiding this comment.
Any thoughts around making this an auto-generated section?
<!-- status autogenerated section -->
There was a problem hiding this comment.
Had to modify mdatagen, but its done.
| @@ -118,7 +118,8 @@ type DependabotData struct { | |||
|
|
|||
| func makePriority(status *Status) int { | |||
| // not an internal component such as pkg/**, and no distributions: | |||
| if len(status.Distributions) == 0 && status.Class != "" { | |||
| if (status.Class == "receiver" || status.Class == "processor" || status.Class == "exporter" || status.Class == "connector" || status.Class == "extension" || status.Class == "cmd") && | |||
There was a problem hiding this comment.
Shouldn't we allow pkg modules now that they can have stability levels?
There was a problem hiding this comment.
This if statement makes it so the priority of pkg (and any other future group like internal) have their priority set using the switch statement below and not this special case. Without these checks, the pkg type was getting the lowest priority because it wasn't in any distributions. That resulted in make gendependabot removing ottl from the dependabot list.
There was a problem hiding this comment.
Got it, thanks. Won't cmd modules hit the same case since they're also not in distributions?
There was a problem hiding this comment.
They don't have class set I believe.
There was a problem hiding this comment.
should gendependabot be affected by this change?
There was a problem hiding this comment.
It was bc gendependabot depends on mdatagen and I had to update mdatagen to handle generating a README for a pkg. OTTL is now the first pkg to include a header in the readme and it broke some assumptions in mdatagen and githubgen.
No description provided.