Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cmd/telemetrygen] Move end to end tests to separate module #27878

Merged
merged 5 commits into from
Oct 20, 2023
Merged

[cmd/telemetrygen] Move end to end tests to separate module #27878

merged 5 commits into from
Oct 20, 2023

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Oct 20, 2023

Description:

Move cmd/telemetrygen integration tests to separate module, to avoid local replaces. Follow up to #26668.

Link to tracking Issue: Fixes #27855

@mx-psi mx-psi requested a review from atoulme October 20, 2023 08:28
@github-actions github-actions bot added the cmd/telemetrygen telemetrygen command label Oct 20, 2023
@mx-psi mx-psi marked this pull request as ready for review October 20, 2023 08:46
@mx-psi mx-psi requested a review from a team as a code owner October 20, 2023 08:46
@mx-psi
Copy link
Member Author

mx-psi commented Oct 20, 2023

cc @theletterf

@mx-psi
Copy link
Member Author

mx-psi commented Oct 20, 2023

From the logs I can confirm the tests are running:

make[2]: Entering directory '/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/cmd/telemetrygen/internal/e2etest'
mkdir -p /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/coverage/unit
go test -race -timeout 300s -parallel 4 --tags="" -cover ./... -covermode=atomic -args -test.gocoverdir="/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/coverage/unit"
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/cmd/telemetrygen/internal/e2etest	1.155s	coverage: [no statements]
make[2]: Leaving directory '/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/cmd/telemetrygen/internal/e2etest'

@mx-psi mx-psi merged commit a504159 into open-telemetry:main Oct 20, 2023
83 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 20, 2023
@mx-psi mx-psi mentioned this pull request Oct 24, 2023
Merged
mx-psi added a commit that referenced this pull request Oct 24, 2023
@mx-psi
[cmd/telemetrygen] Remove remaining replace statement (#28565)
85fba96 
**Description:** #27878 was not enough to fix `go install`, this should
fix it.

**Link to tracking Issue:** Fixes #27855
@mx-psi mx-psi mentioned this pull request Oct 24, 2023
Closed
mx-psi added a commit to mx-psi/opentelemetry-collector-contrib that referenced this pull request Oct 24, 2023
@mx-psi
[cmd/telemetrygen] Remove remaining replace statement (open-telemetry…
3fa1e4b 
…#28565)

**Description:** open-telemetry#27878 was not enough to fix `go install`, this should
fix it.

**Link to tracking Issue:** Fixes open-telemetry#27855

(cherry picked from commit 85fba96)
sigilioso pushed a commit to carlossscastro/opentelemetry-collector-contrib that referenced this pull request Oct 27, 2023
@mx-psi @sigilioso
[cmd/telemetrygen] Move end to end tests to separate module (open-tel…
7583ced 
…emetry#27878)

**Description:** 

Move `cmd/telemetrygen` integration tests to separate module, to avoid
local replaces. Follow up to open-telemetry#26668.

**Link to tracking Issue:** Fixes open-telemetry#27855
sigilioso pushed a commit to carlossscastro/opentelemetry-collector-contrib that referenced this pull request Oct 27, 2023
@mx-psi @sigilioso
[cmd/telemetrygen] Remove remaining replace statement (open-telemetry…
b665836 
…#28565)

**Description:** open-telemetry#27878 was not enough to fix `go install`, this should
fix it.

**Link to tracking Issue:** Fixes open-telemetry#27855
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
@mx-psi @jmsnll
[cmd/telemetrygen] Move end to end tests to separate module (open-tel…
9982776 
…emetry#27878)

**Description:** 

Move `cmd/telemetrygen` integration tests to separate module, to avoid
local replaces. Follow up to open-telemetry#26668.

**Link to tracking Issue:** Fixes open-telemetry#27855
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
@mx-psi @jmsnll
[cmd/telemetrygen] Remove remaining replace statement (open-telemetry…
75f0e87 
…#28565)

**Description:** open-telemetry#27878 was not enough to fix `go install`, this should
fix it.

**Link to tracking Issue:** Fixes open-telemetry#27855
RoryCrispin pushed a commit to ClickHouse/opentelemetry-collector-contrib that referenced this pull request Nov 24, 2023
@mx-psi @RoryCrispin
[cmd/telemetrygen] Remove remaining replace statement (open-telemetry…
5e10bfc 
…#28565)

**Description:** open-telemetry#27878 was not enough to fix `go install`, this should
fix it.

**Link to tracking Issue:** Fixes open-telemetry#27855
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@songy23 songy23 songy23 approved these changes

@crobert-1 crobert-1 crobert-1 approved these changes

@atoulme atoulme Awaiting requested review from atoulme

@codeboten codeboten Awaiting requested review from codeboten codeboten is a code owner

Assignees

@Aneurysm9 Aneurysm9

Labels
cmd/telemetrygen telemetrygen command
Projects
None yet
Milestone
v0.88.0
Development

Successfully merging this pull request may close these issues.

Go install doesn't work for telemetrygen
4 participants
@mx-psi @songy23 @crobert-1 @Aneurysm9