Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][pkg/stanza] Log matching paths #27859

Conversation

djaglowski
Copy link
Member

@djaglowski djaglowski commented Oct 19, 2023

This PR adds a debug log to give visibility into the exact outcome of file matching configuration.

It also removes some fragile logging expectations from batching tests. I believe the meaningful part of the tests remain intact.

@djaglowski djaglowski force-pushed the pkg-stanza-fileconsumer-debug-matches branch from ae494d0 to 4552259 Compare October 19, 2023 16:48
@djaglowski djaglowski force-pushed the pkg-stanza-fileconsumer-debug-matches branch from 4552259 to 24e7612 Compare October 19, 2023 18:17
@djaglowski djaglowski marked this pull request as ready for review October 19, 2023 18:37
@djaglowski djaglowski requested a review from a team as a code owner October 19, 2023 18:37
@djaglowski djaglowski merged commit ac020a2 into open-telemetry:main Oct 19, 2023
85 checks passed
@djaglowski djaglowski deleted the pkg-stanza-fileconsumer-debug-matches branch October 19, 2023 22:24
@github-actions github-actions bot added this to the next release milestone Oct 19, 2023
martin-majlis-s1 pushed a commit to scalyr/opentelemetry-collector-contrib that referenced this pull request Oct 20, 2023
This PR adds a debug log to give visibility into the exact outcome of
file matching configuration.

It also removes some fragile logging expectations from batching tests. I
believe the meaningful part of the tests remain intact.
sigilioso pushed a commit to carlossscastro/opentelemetry-collector-contrib that referenced this pull request Oct 27, 2023
This PR adds a debug log to give visibility into the exact outcome of
file matching configuration.

It also removes some fragile logging expectations from batching tests. I
believe the meaningful part of the tests remain intact.
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
This PR adds a debug log to give visibility into the exact outcome of
file matching configuration.

It also removes some fragile logging expectations from batching tests. I
believe the meaningful part of the tests remain intact.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants