[chore] Send readonly data to immutable exporters in lifecycle tests #27825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
check-exporter-mutability
branch
2 times, most recently
from
7ea8122
to
b9b5698
Compare
dashpole
approved these changes
Oct 18, 2023
dmitryax
force-pushed
the
check-exporter-mutability
branch
from
b9b5698
to
a98034d
Compare
martin-majlis-s1
pushed a commit
to scalyr/opentelemetry-collector-contrib
that referenced
this pull request
Oct 20, 2023
…pen-telemetry#27825) This should help to catch exporters that are incorrectly claimed as not mutating.
martin-majlis-s1
pushed a commit
to scalyr/opentelemetry-collector-contrib
that referenced
this pull request
Oct 20, 2023
…sts (open-telemetry#27848) The lifecycle test passes readonly data to processors claimed as not mutable to catch invalid behavior. Similar to open-telemetry#27825, but for processors tests.
sigilioso
pushed a commit
to carlossscastro/opentelemetry-collector-contrib
that referenced
this pull request
Oct 27, 2023
…pen-telemetry#27825) This should help to catch exporters that are incorrectly claimed as not mutating.
sigilioso
pushed a commit
to carlossscastro/opentelemetry-collector-contrib
that referenced
this pull request
Oct 27, 2023
…sts (open-telemetry#27848) The lifecycle test passes readonly data to processors claimed as not mutable to catch invalid behavior. Similar to open-telemetry#27825, but for processors tests.
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
…pen-telemetry#27825) This should help to catch exporters that are incorrectly claimed as not mutating.
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
…sts (open-telemetry#27848) The lifecycle test passes readonly data to processors claimed as not mutable to catch invalid behavior. Similar to open-telemetry#27825, but for processors tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help to catch exporters that are incorrectly claimed as not mutating.
Built on top of #27824