[cmd/otelcontribcol] Simplify exporters lifecycle tests #27816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to skip tests for components that we don't have factories for. We can just remove those tests. This helped to find a wrong test for nonexistent awscloudwatch exporter
TylerHelmuth
approved these changes
Oct 17, 2023
TylerHelmuth
added
the
Skip Changelog
dmitryax
added a commit
to dmitryax/opentelemetry-collector-contrib
that referenced
this pull request
Oct 17, 2023
This was referenced Oct 17, 2023
dmitryax
added a commit
to dmitryax/opentelemetry-collector-contrib
that referenced
this pull request
Oct 17, 2023
dmitryax
added a commit
that referenced
this pull request
Oct 17, 2023
dmitryax
added a commit
that referenced
this pull request
Oct 17, 2023
JaredTan95
pushed a commit
to openinsight-proj/opentelemetry-collector-contrib
that referenced
this pull request
Oct 18, 2023
…ry#27816) There is no need to skip tests for components that we don't have factories for. We can just remove those tests. This helped to find a wrong test for nonexistent awscloudwatch exporter
JaredTan95
pushed a commit
to openinsight-proj/opentelemetry-collector-contrib
that referenced
this pull request
Oct 18, 2023
JaredTan95
pushed a commit
to openinsight-proj/opentelemetry-collector-contrib
that referenced
this pull request
Oct 18, 2023
sigilioso
pushed a commit
to carlossscastro/opentelemetry-collector-contrib
that referenced
this pull request
Oct 27, 2023
…ry#27816) There is no need to skip tests for components that we don't have factories for. We can just remove those tests. This helped to find a wrong test for nonexistent awscloudwatch exporter
sigilioso
pushed a commit
to carlossscastro/opentelemetry-collector-contrib
that referenced
this pull request
Oct 27, 2023
sigilioso
pushed a commit
to carlossscastro/opentelemetry-collector-contrib
that referenced
this pull request
Oct 27, 2023
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
…ry#27816) There is no need to skip tests for components that we don't have factories for. We can just remove those tests. This helped to find a wrong test for nonexistent awscloudwatch exporter
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to skip tests for components that we don't have factories for. We can just remove those tests. This helped to find a wrong test for nonexistent awscloudwatch exporter