[Spanmetrics] Add events_total metric to get the measurement for list of configured event attributes for a span #27811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aishyandapalli
force-pushed
the
span-metrics-for-events
branch
2 times, most recently
from
43683de
to
89daf3f
Compare
|
cc @albertteoh |
albertteoh
reviewed
Oct 20, 2023
aishyandapalli
force-pushed
the
span-metrics-for-events
branch
from
fdfc91e
to
8bc88cc
Compare
|
@albertteoh Added a check for empty dimensions and also added unit tests |
albertteoh
reviewed
Oct 25, 2023
aishyandapalli
force-pushed
the
span-metrics-for-events
branch
from
32585e0
to
35f815d
Compare
aishyandapalli
force-pushed
the
span-metrics-for-events
branch
3 times, most recently
from
3a62dbd
to
569304c
Compare
djaglowski
approved these changes
Oct 30, 2023
Co-authored-by: Albert <[email protected]>
Co-authored-by: Albert <[email protected]>
Co-authored-by: Albert <[email protected]>
Co-authored-by: Albert <[email protected]>
Co-authored-by: Albert <[email protected]>
Co-authored-by: Albert <[email protected]>
Co-authored-by: Albert <[email protected]>
aishyandapalli
force-pushed
the
span-metrics-for-events
branch
from
2156fa6
to
3960751
Compare
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
… of configured event attributes for a span (open-telemetry#27811) **Description:** We have an events section for a span. The details for all the exceptions like exception.type and exception.message are recorded as Events for a span. Right now, we don't have a feature to add event attributes to span metrics. The idea of this PR is to develop a feature which adds a new metric `events_total` with a default set of dimensions like `service_name, span_name, span_kind, status_code`. We can configure to add additional set of dimensions like `exception.type` and `exception.message` which will be fetched from the Events section for a span **Link to tracking Issue:** [27451](open-telemetry#27451) --------- Co-authored-by: Albert <[email protected]>
RoryCrispin
pushed a commit
to ClickHouse/opentelemetry-collector-contrib
that referenced
this pull request
Nov 24, 2023
… of configured event attributes for a span (open-telemetry#27811) **Description:** We have an events section for a span. The details for all the exceptions like exception.type and exception.message are recorded as Events for a span. Right now, we don't have a feature to add event attributes to span metrics. The idea of this PR is to develop a feature which adds a new metric `events_total` with a default set of dimensions like `service_name, span_name, span_kind, status_code`. We can configure to add additional set of dimensions like `exception.type` and `exception.message` which will be fetched from the Events section for a span **Link to tracking Issue:** [27451](open-telemetry#27451) --------- Co-authored-by: Albert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
We have an events section for a span. The details for all the exceptions like exception.type and exception.message are recorded as Events for a span. Right now, we don't have a feature to add event attributes to span metrics.
The idea of this PR is to develop a feature which adds a new metric
events_totalwith a default set of dimensions likeservice_name, span_name, span_kind, status_code. We can configure to add additional set of dimensions likeexception.typeandexception.messagewhich will be fetched from the Events section for a spanLink to tracking Issue: 27451