Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][pkg/stanza] Add module README #27657

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

djaglowski
Copy link
Member

Resolves #27640

@djaglowski djaglowski marked this pull request as ready for review October 12, 2023 22:59
@djaglowski djaglowski requested a review from a team as a code owner October 12, 2023 22:59
Copy link
Member

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super helpful, thanks so much for adding!

pkg/stanza/README.md Outdated Show resolved Hide resolved
pkg/stanza/README.md Outdated Show resolved Hide resolved
pkg/stanza/README.md Outdated Show resolved Hide resolved
pkg/stanza/README.md Outdated Show resolved Hide resolved
pkg/stanza/README.md Outdated Show resolved Hide resolved
@crobert-1 crobert-1 added the documentation Improvements or additions to documentation label Oct 12, 2023
@djaglowski
Copy link
Member Author

Thanks for catching all those typos. Apparently I put this together too quickly.

Copy link
Contributor

@pjanotti pjanotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djaglowski perfect timing for this PR! Just minor suggestions.

pkg/stanza/README.md Outdated Show resolved Hide resolved
pkg/stanza/README.md Outdated Show resolved Hide resolved
pkg/stanza/README.md Outdated Show resolved Hide resolved
pkg/stanza/README.md Outdated Show resolved Hide resolved
pkg/stanza/README.md Show resolved Hide resolved
pkg/stanza/README.md Outdated Show resolved Hide resolved
@djaglowski djaglowski merged commit c9546e2 into open-telemetry:main Oct 13, 2023
83 checks passed
@djaglowski djaglowski deleted the pkg-stanza-readme branch October 13, 2023 14:30
@github-actions github-actions bot added this to the next release milestone Oct 13, 2023
JaredTan95 pushed a commit to openinsight-proj/opentelemetry-collector-contrib that referenced this pull request Oct 18, 2023
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation pkg/stanza
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pkg/stanza] README request
5 participants