feat: add integration test for syslog exporter (and receiver) #27464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumo-drosiek
requested review from
a team,
djaglowski and
andrzej-stencel
as code owners
sumo-drosiek
force-pushed
the
drosiek-integration-tests
branch
5 times, most recently
from
259dadb
to
c6b8605
Compare
sumo-drosiek
commented
Oct 9, 2023
Comment on lines
+186
to
+191
| for i := 0; i < lrs.Len(); i++ { | ||
| lrs.At(i).SetObservedTimestamp(0) | ||
|
|
||
| attributes = append(attributes, lrs.At(i).Attributes().AsRaw()) | ||
| lrs.At(i).Attributes().Clear() | ||
| } |
There was a problem hiding this comment.
I should perform assertions here instead of changing the received objects. Will improve it
djaglowski
approved these changes
Oct 9, 2023
| attributes map[string]interface{} | ||
| } | ||
|
|
||
| func TestSyslogComplementaryRFC5424(t *testing.T) { |
There was a problem hiding this comment.
Both these tests randomly fail on my machine, apparently due to the two syslog messages arriving in different order than sent. We have investigated this with @sumo-drosiek and we believe we found the cause and the fix for this. I was actually just going to submit this fix in relation to this issue: #21244. I'm fine with merging this PR as long as the CI tests pass, I will submit the fix in a separate PR.
testbed/datareceivers/carbon.go
Outdated
| @@ -24,7 +24,7 @@ type CarbonDataReceiver struct { | |||
| receiver receiver.Metrics | |||
| } | |||
|
|
|||
| // Ensure CarbonDataReceiver implements MetricDataSender. | |||
| // Ensure CarbonDataReceiver implements MetricDataReceiver. | |||
There was a problem hiding this comment.
I don't think there's such a thing as MetricDataReceiver, at least not anymore. 😉
This code seems to ensure that the CarbonDataReceiver implements the testbed.DataReceiver interface.
sumo-drosiek
force-pushed
the
drosiek-integration-tests
branch
from
589c6e4
to
a2a5a3e
Compare
Signed-off-by: Dominik Rosiek <[email protected]>
sumo-drosiek
force-pushed
the
drosiek-integration-tests
branch
from
a2a5a3e
to
fc40519
Compare
djaglowski
reviewed
Oct 13, 2023
Co-authored-by: Daniel Jaglowski <[email protected]>
Signed-off-by: Dominik Rosiek <[email protected]>
djaglowski
approved these changes
Oct 16, 2023
JaredTan95
pushed a commit
to openinsight-proj/opentelemetry-collector-contrib
that referenced
this pull request
Oct 18, 2023
…elemetry#27464) **Description:** Adding integration tests for syslog exporter (and syslog receiver) and fixing bugs which has been found during the process **Link to tracking Issue:** open-telemetry#21245 **Testing:** Integration tests and more unit tests **Documentation:** N/A --------- Signed-off-by: Dominik Rosiek <[email protected]> Co-authored-by: Daniel Jaglowski <[email protected]>
djaglowski
pushed a commit
that referenced
this pull request
Oct 30, 2023
**Description:** This changes the behavior of the Syslog exporter to send each batch of Syslog messages in a single request (with messages separated by newlines), instead of sending each message in a separate request and closing the connection after each message. The batching only happens when using TCP. For UDP, each syslog message is still sent in a separate request, as defined by [the spec](https://datatracker.ietf.org/doc/html/rfc5426#section-3.1). This also significantly refactors (and hopefully simplifies) the exporter's code, extracting the code that formats the syslog messages from the `sender` type into separate `formatter` types. Hopefully this will make the development of this component easier. **Link to tracking Issue:** - #21244 **Testing:** The unit tests have been updated to reflect the refactored codebase. The integration tests introduced in #27464 are unchanged, as the format of the output messages hasn't changed. **Documentation:** No documentation updates.
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
…elemetry#27464) **Description:** Adding integration tests for syslog exporter (and syslog receiver) and fixing bugs which has been found during the process **Link to tracking Issue:** open-telemetry#21245 **Testing:** Integration tests and more unit tests **Documentation:** N/A --------- Signed-off-by: Dominik Rosiek <[email protected]> Co-authored-by: Daniel Jaglowski <[email protected]>
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
**Description:** This changes the behavior of the Syslog exporter to send each batch of Syslog messages in a single request (with messages separated by newlines), instead of sending each message in a separate request and closing the connection after each message. The batching only happens when using TCP. For UDP, each syslog message is still sent in a separate request, as defined by [the spec](https://datatracker.ietf.org/doc/html/rfc5426#section-3.1). This also significantly refactors (and hopefully simplifies) the exporter's code, extracting the code that formats the syslog messages from the `sender` type into separate `formatter` types. Hopefully this will make the development of this component easier. **Link to tracking Issue:** - open-telemetry#21244 **Testing:** The unit tests have been updated to reflect the refactored codebase. The integration tests introduced in open-telemetry#27464 are unchanged, as the format of the output messages hasn't changed. **Documentation:** No documentation updates.
RoryCrispin
pushed a commit
to ClickHouse/opentelemetry-collector-contrib
that referenced
this pull request
Nov 24, 2023
**Description:** This changes the behavior of the Syslog exporter to send each batch of Syslog messages in a single request (with messages separated by newlines), instead of sending each message in a separate request and closing the connection after each message. The batching only happens when using TCP. For UDP, each syslog message is still sent in a separate request, as defined by [the spec](https://datatracker.ietf.org/doc/html/rfc5426#section-3.1). This also significantly refactors (and hopefully simplifies) the exporter's code, extracting the code that formats the syslog messages from the `sender` type into separate `formatter` types. Hopefully this will make the development of this component easier. **Link to tracking Issue:** - open-telemetry#21244 **Testing:** The unit tests have been updated to reflect the refactored codebase. The integration tests introduced in open-telemetry#27464 are unchanged, as the format of the output messages hasn't changed. **Documentation:** No documentation updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adding integration tests for syslog exporter (and syslog receiver) and fixing bugs which has been found during the process
Link to tracking Issue: #21245
Testing:
Integration tests and more unit tests
Documentation:
N/A