[chore][extension/filestorage] Fix flaky test on windows #27421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaglowski
force-pushed
the
storage-fix-test
branch
from
779b5b0
to
b4cd3c8
Compare
songy23
approved these changes
Oct 4, 2023
sumo-drosiek
pushed a commit
to sumo-drosiek/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2023
…try#27421) This test failed on windows ([here](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/6400499092/job/17374210350#step:6:659)), apparently because the storage file is still open when the test framework attempts to clean up the directory.
jorgeancal
pushed a commit
to jorgeancal/opentelemetry-collector-contrib
that referenced
this pull request
Oct 9, 2023
…try#27421) This test failed on windows ([here](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/6400499092/job/17374210350#step:6:659)), apparently because the storage file is still open when the test framework attempts to clean up the directory.
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
…try#27421) This test failed on windows ([here](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/6400499092/job/17374210350#step:6:659)), apparently because the storage file is still open when the test framework attempts to clean up the directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test failed on windows (here), apparently because the storage file is still open when the test framework attempts to clean up the directory.