[processor/metricstransformprocessor] fix copy exponential histogram #27410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
processor/metricstransform
crobert-1
approved these changes
Oct 3, 2023
dmitryax
approved these changes
Oct 3, 2023
|
Thanks for the fix, @mfranklin! |
|
@mfranklin can you please add a changelog item to https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/.chloggen? |
@mfranklin: You can run |
mfranklin
force-pushed
the
mfranklin/metricstransformer-exponential-histogram-copy
branch
from
891575f
to
f5c5986
Compare
crobert-1
added
the
ready to merge
|
Changelog added. |
codeboten
approved these changes
Oct 6, 2023
jorgeancal
pushed a commit
to jorgeancal/opentelemetry-collector-contrib
that referenced
this pull request
Oct 9, 2023
…pen-telemetry#27410) Fixes a bug where the wrong function was called for the exponential histogram type during the copy operation. Fixes open-telemetry#27409 Added a test for `combine` that covers the failing code path.
mfranklin
deleted the
mfranklin/metricstransformer-exponential-histogram-copy
branch
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
…pen-telemetry#27410) Fixes a bug where the wrong function was called for the exponential histogram type during the copy operation. Fixes open-telemetry#27409 Added a test for `combine` that covers the failing code path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes a bug where the wrong function was called for the exponential histogram type during the copy operation.
Link to tracking Issue:
Fixes #27409
Testing:
Added a test for
combinethat covers the failing code path.Documentation:
No documentation added as this is a simple bug fix.