Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exporter/signalfx: Update exclude_metrics option #2737

Merged

Conversation

asuresh4
Copy link
Member

Description: Update the behavior of exclude_metrics option. The PR updates the behavior so that the default exclude rules can be overridden by setting exclude_metrics to []. Currently, the exporter appends a list of default exclude rules. This update will mean that the exporter only appends default rules for if exclude_metrics is not specified or is a non-empty slice.

Link to tracking Issue:

Testing: Added tests.

Documentation: Updated README

@asuresh4 asuresh4 requested a review from a team as a code owner March 18, 2021 20:06
@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #2737 (5a81216) into main (f8c550f) will increase coverage by 1.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2737      +/-   ##
==========================================
+ Coverage   90.53%   91.59%   +1.05%     
==========================================
  Files         444      445       +1     
  Lines       21984    22058      +74     
==========================================
+ Hits        19904    20203     +299     
+ Misses       1618     1385     -233     
- Partials      462      470       +8     
Flag Coverage Δ
integration 69.18% <ø> (?)
unit 90.52% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
exporter/signalfxexporter/factory.go 82.45% <100.00%> (-0.31%) ⬇️
receiver/k8sclusterreceiver/watcher.go 95.29% <0.00%> (-2.36%) ⬇️
processor/groupbytraceprocessor/event.go 95.96% <0.00%> (-0.81%) ⬇️
internal/common/testing/container/container.go 73.68% <0.00%> (ø)
receiver/jmxreceiver/receiver.go 94.80% <0.00%> (+16.88%) ⬆️
receiver/dockerstatsreceiver/docker.go 92.30% <0.00%> (+39.05%) ⬆️
receiver/dockerstatsreceiver/receiver.go 96.72% <0.00%> (+47.54%) ⬆️
receiver/jmxreceiver/subprocess/subprocess.go 96.55% <0.00%> (+74.48%) ⬆️
receiver/redisreceiver/receiver.go 87.50% <0.00%> (+87.50%) ⬆️
receiver/redisreceiver/client.go 100.00% <0.00%> (+100.00%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8c550f...5a81216. Read the comment docs.

@bogdandrutu bogdandrutu merged commit deb6efe into open-telemetry:main Mar 19, 2021
pmatyjasek-sumo referenced this pull request in pmatyjasek-sumo/opentelemetry-collector-contrib Apr 28, 2021
alexperez52 referenced this pull request in open-o11y/opentelemetry-collector-contrib Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants