Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Kafka receiver and exporter TLS docs #27291

Merged

Conversation

andreasgerstmayr
Copy link
Contributor

Description:
ca_file, cert_file and key_file should only be used if insecure is set to false, otherwise client TLS is disabled: https://github.com/open-telemetry/opentelemetry-collector/blob/7c5ecef11dff4ce5501c9683b277a25a61ea0f1a/config/configtls/README.md

Testing:
No code change, only docs.

`ca_file`, `cert_file` and `key_file` should only be used if `insecure`
is set to `false`, otherwise client TLS is disabled:
https://github.com/open-telemetry/opentelemetry-collector/blob/7c5ecef11dff4ce5501c9683b277a25a61ea0f1a/config/configtls/README.md

Signed-off-by: Andreas Gerstmayr <[email protected]>
@songy23 songy23 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Oct 2, 2023
@codeboten codeboten added the ready to merge Code review completed; ready to merge by maintainers label Oct 6, 2023
@codeboten codeboten merged commit 97cde11 into open-telemetry:main Oct 6, 2023
101 of 103 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 6, 2023
jorgeancal pushed a commit to jorgeancal/opentelemetry-collector-contrib that referenced this pull request Oct 9, 2023
`ca_file`, `cert_file` and `key_file` should only be used if `insecure`
is set to `false`, otherwise client TLS is disabled:
https://github.com/open-telemetry/opentelemetry-collector/blob/7c5ecef11dff4ce5501c9683b277a25a61ea0f1a/config/configtls/README.md

Signed-off-by: Andreas Gerstmayr <[email protected]>
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
`ca_file`, `cert_file` and `key_file` should only be used if `insecure`
is set to `false`, otherwise client TLS is disabled:
https://github.com/open-telemetry/opentelemetry-collector/blob/7c5ecef11dff4ce5501c9683b277a25a61ea0f1a/config/configtls/README.md

Signed-off-by: Andreas Gerstmayr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter/kafka ready to merge Code review completed; ready to merge by maintainers receiver/kafka Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants