[exporter/elasticsearch] add missing scope info in span/log attributes #27288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jared Tan <[email protected]>
crobert-1
approved these changes
Oct 2, 2023
|
Logs missing also. |
songy23
approved these changes
Oct 18, 2023
**Description:** Remove the parquet exporter **Link to tracking Issue:** Fixes open-telemetry#27284
…etry#27235) **Description:** Functions to modify matched text during replacement can now be passed as optional arguments to the following Editors: - replace_pattern - replace_all_patterns - replace_match - replace_all_matches **Documentation:** https://github.com/rnishtala-sumo/opentelemetry-collector-contrib/blob/ottl-replace-pattern/pkg/ottl/ottlfuncs/README.md#replace_pattern **Issue:** Resolves open-telemetry#22787
**Description:** Add validation of protocol name and be case insensitive **Link to tracking Issue:** **Testing:** Unit Tests **Documentation:** N/A --------- Signed-off-by: Dominik Rosiek <[email protected]>
…r.Factory and pass checkapi (open-telemetry#27077) Related to: open-telemetry#26304
…oudwatchlogs exporter (open-telemetry#26692) Adds support to the to parallelism in the awscloudwatchlogs exporter by leveraging the [exporter helper](https://github.com/open-telemetry/opentelemetry-collector/blob/main/exporter/exporterhelper/README.md). In this PR, we are adding support to the `num_consumers` configuration in the `sending_queue`. This will allow users to specify the number of consumers that will consume from the sending_queue in parallel. It is possible and straightforward to use this approach because CloudWatch logs [no longer requires that you use a token to control access to the stream that you are writing to](https://aws.amazon.com/about-aws/whats-new/2023/01/amazon-cloudwatch-logs-log-stream-transaction-quota-sequencetoken-requirement/). You can write to the same stream in parallel. To achieve this, this PR does the following: * Create Pusher that is able to push to multiple streams at the same time. * Move lifecycle of the Pusher to the function that is used to consume from the sending queue. This allows you to safely send to multiple streams at the same time without any resource contention since each call to consume logs will not share resources with others that are happening in parallel (one exception is the creation of log streams). Besides that I analyzed the code and removed other limitations: * locks that were not necessary * Limiter that was used to limit the number of requests per stream to 5 per second. [The TPS is much higher now and is per account.](https://aws.amazon.com/about-aws/whats-new/2023/01/amazon-cloudwatch-logs-log-stream-transaction-quota-sequencetoken-requirement/) ** How to review this PR: ** The first 3 commits in this PR were used to refactor the code before making the real changes. Please use the commits to simplify the review process. **Link to tracking Issue:** open-telemetry#26360 **Testing:** - Unit tests were added. - Tested locally sending logs to cloudwatch logs. **Documentation:** Documentation was added describing the new parameters. --------- Signed-off-by: Raphael Silva <[email protected]> Co-authored-by: Anthony Mirabella <[email protected]>
…pen-telemetry#23447) Adding a feature: Making `maxBatchByteSize` a configurable parameter. This would allow users to adjust it based on the capabilities of their specific remote storage, offering more flexibility and potentially improving performance. Example: ```yaml exporters: prometheusremotewrite: endpoint: "https://my-cortex:7900/api/v1/push" max_batch_byte_size: 5000000 ``` Fixes open-telemetry#21911 **Testing:** <Describe what testing was performed and which tests were added.> Added `MaxBatchByteSize` to `TestLoadConfig(t *testing.T)` in `config_test.go` **Documentation:** <Describe the documentation added.> Added to `README.md`: - `max_batch_byte_size` (default = `3000000` -> `~2.861 mb`): Maximum size of a batch of samples to be sent to the remote write endpoint. If the batch size is larger than this value, it will be split into multiple batches. --------- Co-authored-by: Alex Boten <[email protected]>
…pen-telemetry#27625) **Description:** v0.87.0 `exporterhelper.queue_settings.validate()` verifies the consumer setting for us. We no longer need to duplicate that validation. **Link to tracking Issue:** <Issue number if applicable> open-telemetry#27624
…#27434) Incremental step towards decoupling the Reader struct. This also clarifies and corrects the behavior of the `ValidateOrClose` function.
This addresses https://pkg.go.dev/vuln/GO-2023-2102 Signed-off-by: Alex Boten <[email protected]>
open-telemetry#27616) **Description:** This resource attribute was deprecated in prior release ( open-telemetry#27584) so I am removing it. **Link to tracking Issue:** open-telemetry#26487
…elemetry#27569) **Description:** Adds an e2e test for the k8sobjectsreceiver to github workflow <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> **Link to tracking Issue:** [18395](open-telemetry#18395)
…#27622) **Description:** Remove stale go mod replace for datadog-agent and upgrade to the released version. **Link to tracking Issue:** Fixes open-telemetry#25119.
…try#27634) Remove translation dropping the `opencensus.resourcetype` resource attribute as it's not emitted by k8s receivers anymore. The last one was removed in open-telemetry#27616
**Documentation:** <Describe the documentation added.> Found a typo while reading the transform processor readme.
…open-telemetry#27272) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Added support for Exporter Helper configuration. **Link to tracking Issue:** open-telemetry#24329 **Testing:** <Describe what testing was performed and which tests were added.> Added tests and manually tested with e2e scenarios --------- Co-authored-by: Ramachandran A G <[email protected]> Co-authored-by: Ziqi Zhao <[email protected]> Co-authored-by: Ramachandran A G <[email protected]>
open-telemetry#27485) **Description:** <Describe what has changed.> add k8s.pod.qos_class optional resource attriute **Link to tracking Issue:** <Issue number if applicable> open-telemetry#27483 **Testing:** <Describe what testing was performed and which tests were added.> - updated unit tests **Documentation:** <Describe the documentation added.> - generated
JaredTan95
removed
cmd/mdatagen
|
you seemed add a lot of unrelated commits @JaredTan95 |
maybe it was caused by rebase. but don't mind, It will be squashed during the merge. |
JaredTan95
changed the title
mx-psi
approved these changes
Oct 23, 2023
sigilioso
added a commit
to carlossscastro/opentelemetry-collector-contrib
that referenced
this pull request
Oct 27, 2023
open-telemetry#27288) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> **Link to tracking Issue:** open-telemetry#27282 **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.> --------- Signed-off-by: Jared Tan <[email protected]> Signed-off-by: Dominik Rosiek <[email protected]> Signed-off-by: Raphael Silva <[email protected]> Signed-off-by: Alex Boten <[email protected]> Signed-off-by: Pavol Loffay <[email protected]> Co-authored-by: Antoine Toulme <[email protected]> Co-authored-by: Raj Nishtala <[email protected]> Co-authored-by: Dominik Rosiek <[email protected]> Co-authored-by: Povilas Versockas <[email protected]> Co-authored-by: Priyanshu Raj <[email protected]> Co-authored-by: sakulali <[email protected]> Co-authored-by: Raphael Philipe Mendes da Silva <[email protected]> Co-authored-by: Anthony Mirabella <[email protected]> Co-authored-by: Yotam loewenbach <[email protected]> Co-authored-by: Alex Boten <[email protected]> Co-authored-by: bryan-aguilar <[email protected]> Co-authored-by: Daniel Jaglowski <[email protected]> Co-authored-by: Jina Jain <[email protected]> Co-authored-by: Yang Song <[email protected]> Co-authored-by: Dmitrii Anoshin <[email protected]> Co-authored-by: Curtis Robert <[email protected]> Co-authored-by: Abhishek Saharn <[email protected]> Co-authored-by: Ramachandran A G <[email protected]> Co-authored-by: Ziqi Zhao <[email protected]> Co-authored-by: Ramachandran A G <[email protected]> Co-authored-by: Faith Chikwekwe <[email protected]> Co-authored-by: Tyler Helmuth <[email protected]> Co-authored-by: Daniel Kuiper <[email protected]> Co-authored-by: Carlos Castro <[email protected]> Co-authored-by: Christian <[email protected]> Co-authored-by: ArchangelSDY <[email protected]> Co-authored-by: Pavol Loffay <[email protected]> Co-authored-by: Paulo Janotti <[email protected]> Co-authored-by: Nathan Burke <[email protected]> Co-authored-by: VihasMakwana <[email protected]> Co-authored-by: shalper2 <[email protected]> Co-authored-by: OpenTelemetry Bot <[email protected]> Co-authored-by: Martin Majlis <[email protected]> Co-authored-by: hovavza <[email protected]>
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
open-telemetry#27288) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> **Link to tracking Issue:** open-telemetry#27282 **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.> --------- Signed-off-by: Jared Tan <[email protected]> Signed-off-by: Dominik Rosiek <[email protected]> Signed-off-by: Raphael Silva <[email protected]> Signed-off-by: Alex Boten <[email protected]> Signed-off-by: Pavol Loffay <[email protected]> Co-authored-by: Antoine Toulme <[email protected]> Co-authored-by: Raj Nishtala <[email protected]> Co-authored-by: Dominik Rosiek <[email protected]> Co-authored-by: Povilas Versockas <[email protected]> Co-authored-by: Priyanshu Raj <[email protected]> Co-authored-by: sakulali <[email protected]> Co-authored-by: Raphael Philipe Mendes da Silva <[email protected]> Co-authored-by: Anthony Mirabella <[email protected]> Co-authored-by: Yotam loewenbach <[email protected]> Co-authored-by: Alex Boten <[email protected]> Co-authored-by: bryan-aguilar <[email protected]> Co-authored-by: Daniel Jaglowski <[email protected]> Co-authored-by: Jina Jain <[email protected]> Co-authored-by: Yang Song <[email protected]> Co-authored-by: Dmitrii Anoshin <[email protected]> Co-authored-by: Curtis Robert <[email protected]> Co-authored-by: Abhishek Saharn <[email protected]> Co-authored-by: Ramachandran A G <[email protected]> Co-authored-by: Ziqi Zhao <[email protected]> Co-authored-by: Ramachandran A G <[email protected]> Co-authored-by: Faith Chikwekwe <[email protected]> Co-authored-by: Tyler Helmuth <[email protected]> Co-authored-by: Daniel Kuiper <[email protected]> Co-authored-by: Carlos Castro <[email protected]> Co-authored-by: Christian <[email protected]> Co-authored-by: ArchangelSDY <[email protected]> Co-authored-by: Pavol Loffay <[email protected]> Co-authored-by: Paulo Janotti <[email protected]> Co-authored-by: Nathan Burke <[email protected]> Co-authored-by: VihasMakwana <[email protected]> Co-authored-by: shalper2 <[email protected]> Co-authored-by: OpenTelemetry Bot <[email protected]> Co-authored-by: Martin Majlis <[email protected]> Co-authored-by: hovavza <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Link to tracking Issue: #27282
Testing:
Documentation: